<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1794/">https://reviewboard.asterisk.org/r/1794/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Go for it.</pre>
<br />
<p>- Mark</p>
<br />
<p>On March 6th, 2012, 11:37 a.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated March 6, 2012, 11:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As a result of a (ok, *my*) previous attempt at fixing a CDR bug (when I knew that it is *always* a mistake to try to fix CDR bugs), setting CDR variables in the hangup extension was broken.
The previous patch copies over CDR variables from the channel in case they were set during the bridge via custom feature codes. Unfortunately, if there is a hangup extension, the bridge CDR is actually swapped out with the channel CDR. In this case, we would be overwriting any changes that happened in the hangup extension with most-likely blank values. This patch just modifies the original patch to not do the copy if we previously did the hangup extension stuff.
So I am now "fixing" CDRs, which should never be "fixed", because in my arrogance I felt that I could really fix a "small" bug in them. Let this be a lesson to you.
P.S. Yes, I'm aware that I'm breaking my own rule yet again. Somebody should probably tie me down so that I can't touch the code anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested that setting the accountcode during the bridge still works, and that setting in the hangup extension also works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/main/features.c <span style="color: grey">(358376)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1794/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>