<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
On 02/03/12 09:04, Terry Wilson wrote:
<blockquote
cite="mid:20120301220415.15471.43121@hotblack.digium.com"
type="cite">
<div style="font-family: Verdana,Arial,Helvetica,Sans-Serif;">
<table style="border: 1px solid rgb(201, 195, 153);"
width="100%" bgcolor="#f9f3c9" cellpadding="8">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To reply,
visit: <a moz-do-not-send="true"
href="https://reviewboard.asterisk.org/r/1784/">https://reviewboard.asterisk.org/r/1784/</a>
</td>
</tr>
</tbody>
</table>
<br>
<blockquote style="margin-left: 1em; border-left: 2px solid
rgb(208, 208, 208); padding-left: 10px;">
<p style="margin-top: 0pt;">On March 1st, 2012, 12:05 a.m., <b>wedhorn</b>
wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid
rgb(208, 208, 208); padding-left: 10px;">
<pre style="white-space: pre-wrap; word-wrap: break-word;">Apart from the above, it appears there's only a single use for softhangup_internal_flag_set in ast_do_masquerade (line 6651 of channel.c). While I appreciate it's a bit off topic for your patch, does anyone actually see a reason for removing all of the _softhangup flags before setting it to AST_SOFTHANGUP_DEV? If not, this could be changed to flag_add and flag_set be removed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; word-wrap: break-word;">The softhangup flag in general is a big mess. Nothing is supposed to set it directly, but everything does and you can't use the existing setter function without breaking things. There is a lot of stuff that needs to happen with that code. And yes. That should definitely just be an add. It might have been changed manually before I looked at that and said "hell, no...we're adding an _add() function." :-)</pre>
<br>
</div>
</blockquote>
Terry, you seem to have forgotten to correct line 7733 of chan_dahdi
to a softhangup_internal_flag_add before committing.<br>
<br>
Damien<br>
<br>
</body>
</html>