<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1784/">https://reviewboard.asterisk.org/r/1784/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1784/diff/1/?file=25139#file25139line7733" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/channels/chan_dahdi.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int attempt_transfer(struct dahdi_pvt *p)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">7733</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">p</span><span class="o">-></span><span class="n">subs</span><span class="p">[</span><span class="n">SUB_THREEWAY</span><span class="p">].</span><span class="n">owner</span><span class="o">-></span><span class="n">_softhangup</span> <span class="o">|=</span> <span class="n">AST_SOFTHANGUP_DEV</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">7733</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_channel_softhangup_internal_flag_set</span><span class="p">(</span><span class="n">p</span><span class="o">-></span><span class="n">subs</span><span class="p">[</span><span class="n">SUB_THREEWAY</span><span class="p">].</span><span class="n">owner</span><span class="p">,</span> <span class="n">ast_channel_softhangup_internal_flag</span><span class="p">(</span><span class="n">p</span><span class="o">-></span><span class="n">subs</span><span class="p">[</span><span class="n">SUB_THREEWAY</span><span class="p">].</span><span class="n">owner</span><span class="p">)</span> <span class="o">|</span> <span class="n">AST_SOFTHANGUP_DEV</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't this just be a simple softhangup_internal_flag_add?</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apart from the above, it appears there's only a single use for softhangup_internal_flag_set in ast_do_masquerade (line 6651 of channel.c). While I appreciate it's a bit off topic for your patch, does anyone actually see a reason for removing all of the _softhangup flags before setting it to AST_SOFTHANGUP_DEV? If not, this could be changed to flag_add and flag_set be removed.</pre>
<p>- wedhorn</p>
<br />
<p>On February 29th, 2012, 1:04 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Feb. 29, 2012, 1:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">More oapquification. Most of the array stuff was done manually. So look carefully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unit tests and testsuite look good.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_dahdibarge.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_dahdiras.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_directed_pickup.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_dumpchan.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_flash.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_meetme.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_queue.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_agent.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_mgcp.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_misdn.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_phone.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_vpb.cc <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/console_video.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/sig_pri.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/sig_ss7.c <span style="color: grey">(357542)</span></li>
<li>/trunk/funcs/func_channel.c <span style="color: grey">(357542)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(357542)</span></li>
<li>/trunk/main/autoservice.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/channel_internal_api.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/dsp.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/file.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(357542)</span></li>
<li>/trunk/res/snmp/agent.c <span style="color: grey">(357542)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1784/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>