<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1743/">https://reviewboard.asterisk.org/r/1743/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 28th, 2012, 3:34 a.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1743/diff/1/?file=24221#file24221line699" style="color: black; font-weight: bold; text-decoration: underline;">trunk/main/data.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static struct ast_data_search *data_search_alloc(const char *name)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">699</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">res</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">699</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">res</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">children</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FIXME: double check that this is right</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am quite sure this is correct. The previous code doesn't even make sense. You can't lower the refcount of NULL.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 28th, 2012, 3:34 a.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1743/diff/1/?file=24221#file24221line1656" style="color: black; font-weight: bold; text-decoration: underline;">trunk/main/data.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static struct data_filter *data_filter_alloc(const char *name)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1656</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">res</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1656</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">res</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">children</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FIXME: double check that this is right</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ditto.</pre>
<br />
<p>- Tilghman</p>
<br />
<p>On March 1st, 2012, 12:22 a.m., junky wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By junky.</div>
<p style="color: grey;"><i>Updated March 1, 2012, 12:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is to prevent many more cppcheck warnings.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">used cppcheck 1.52
it compiles ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/apps/app_minivm.c <span style="color: grey">(357660)</span></li>
<li>trunk/apps/app_osplookup.c <span style="color: grey">(357660)</span></li>
<li>trunk/cdr/cdr_pgsql.c <span style="color: grey">(357660)</span></li>
<li>trunk/cdr/cdr_sqlite3_custom.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_alsa.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_dahdi.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_gtalk.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_h323.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_unistim.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/vcodecs.c <span style="color: grey">(357660)</span></li>
<li>trunk/codecs/codec_dahdi.c <span style="color: grey">(357660)</span></li>
<li>trunk/codecs/codec_resample.c <span style="color: grey">(357660)</span></li>
<li>trunk/formats/format_h264.c <span style="color: grey">(357660)</span></li>
<li>trunk/funcs/func_devstate.c <span style="color: grey">(357660)</span></li>
<li>trunk/funcs/func_env.c <span style="color: grey">(357660)</span></li>
<li>trunk/main/ast_expr2.fl <span style="color: grey">(357660)</span></li>
<li>trunk/main/ast_expr2f.c <span style="color: grey">(357660)</span></li>
<li>trunk/main/asterisk.c <span style="color: grey">(357660)</span></li>
<li>trunk/main/data.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_config_ldap.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_config_sqlite3.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_corosync.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_format_attr_celt.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_format_attr_silk.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_http_post.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_jabber.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_musiconhold.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_odbc.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_phoneprov.c <span style="color: grey">(357660)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1743/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>