<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1760/">https://reviewboard.asterisk.org/r/1760/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. Typically, we take measures so that a deprecation warning will only ever print one time. That way the logs don't get spammed with the warning too much. If you make that change, this is good to go.</pre>
<br />
<p>- Mark</p>
<br />
<p>On February 27th, 2012, 8:34 a.m., opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2012, 8:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To help along the deprecation of app_macro, this enables the use of app_stack (aka GoSub) in relation to connected line, redirecting, and call completion supplementary services. The only major changes between the two implementations involve dropping the distinction between caller and callee for connected line and redirecting since this distinction never really made sense in the first place.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the new tests to go with these changes here: https://reviewboard.asterisk.org/r/1761/</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SWP-4254">SWP-4254</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/configs/ccss.conf.sample <span style="color: grey">(356213)</span></li>
<li>trunk/include/asterisk/app.h <span style="color: grey">(356213)</span></li>
<li>trunk/include/asterisk/ccss.h <span style="color: grey">(356213)</span></li>
<li>trunk/include/asterisk/channel.h <span style="color: grey">(356213)</span></li>
<li>trunk/apps/app_followme.c <span style="color: grey">(356213)</span></li>
<li>trunk/apps/app_queue.c <span style="color: grey">(356213)</span></li>
<li>trunk/UPGRADE.txt <span style="color: grey">(356213)</span></li>
<li>trunk/apps/app_dial.c <span style="color: grey">(356213)</span></li>
<li>trunk/main/app.c <span style="color: grey">(356213)</span></li>
<li>trunk/main/ccss.c <span style="color: grey">(356213)</span></li>
<li>trunk/main/channel.c <span style="color: grey">(356213)</span></li>
<li>trunk/main/dial.c <span style="color: grey">(356213)</span></li>
<li>trunk/main/features.c <span style="color: grey">(356213)</span></li>
<li>trunk/main/rtp_engine.c <span style="color: grey">(356213)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1760/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>