<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1771/">https://reviewboard.asterisk.org/r/1771/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 24th, 2012, 8:37 a.m., <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ironically, that's one of the things I *like* about that command-line switch. Its handy to be able to run a subset of tests that fit within a particular genre. Particularly things like run all SIP tests:
./runtests.py --test=tests/channels/SIP
I'm fine with changing this to run just one test, but I'd prefer there to still be an option that does matching.</pre>
</blockquote>
<p>On February 24th, 2012, 8:48 a.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this patch is committed, we can always use the tag system to run subsets of tests. The downside is that not all tests are tagged properly and some non-trivial amount of time will be required to ensure that they are.</pre>
</blockquote>
<p>On February 24th, 2012, 9:16 a.m., <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For Matt's case, couldn't you just let the shell expand '*' for you and do something like ./runtests.py --tests=tests/channels/SIP/* ?</pre>
</blockquote>
<p>On February 25th, 2012, 3:14 p.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shell expansion doesn't make sense for option-arguments -- unless you emulate it using the glob module, but that can require awkward quoting. (--test=tests/* vs. -t 'tests/*').
However, since these tests are mapped to actual files, one could argue that individual tests are the de facto arguments to runtests:
altering the option parser to take tests as non-option arguments instead of -t argument(s) might be a good idea.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought about this some more over the weekend, and I think that this patch is the right approach. Kinsey's tags would allow us to define subsets of tests to run with a finer degree of granularity that is currently available, and the -t option does imply that it runs a single test. If we want to modify that such that it isn't even needed, and we can run multiple tests by specifying each test as an argument to the script, that'd be fine too.
I'll think about tagging the tests with some defaults this week and put them up on a wiki page - I don't think that necessarily has to be a part of this patch.</pre>
<br />
<p>- Matt</p>
<br />
<p>On February 24th, 2012, 3:02 a.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2012, 3:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">./runtests.py -t tests/channels/SIP/sip_register
matched
tests/channels/SIP/sip_register
tests/channels/SIP/sip_register_domain_acl
with patch it only matches
tests/channels/SIP/sip_register
(The whole -t bit could use a bit of refactoring, this is just a quick-fix.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tests/channels/SIP
still matches all SIP tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/runtests.py <span style="color: grey">(3064)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1771/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>