<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/672/">https://reviewboard.asterisk.org/r/672/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks like the IANA assignments have been updated to reflect our implementation, so this is no longer an issue. It's up to you whether to update the source from decimal to hex, but I think you're good to go either way.</pre>
<br />
<p>- Sean</p>
<br />
<p>On May 21st, 2010, 9:04 a.m., Kevin Fleming wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin Fleming.</div>
<p style="color: grey;"><i>Updated May 21, 2010, 9:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While preparing to document some new possible IAX2 support, I cross-checked the IAX2 control subclass and information element definitions in iax2.h against the registered values in the IANA registries. This comparison was harder than it needed to be because the values in iax2.h were in decimal and not hexadecimal, so the attached patch changes that.
However, while doing this comparison, I found a mismatch that we'll need to discuss how to address. We are using 0x34 as IAX_IE_VARIABLE but in the IANA registry this value is for IAX_IE_OSPTOKEN (which we have 0x35 for). Changing this will break backwards compatibility, but as it stands, we are not compatible with the IANA-registered definitions, so something has to change or implementations written to the specifications won't interoperate with Asterisk properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile testing; there are no functional changes here yet.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/iax2.h <span style="color: grey">(264951)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/672/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>