<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1770/">https://reviewboard.asterisk.org/r/1770/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">reviewing this is sooooooooooooo fun</pre>
<br />
<p>- Mark</p>
<br />
<p>On February 23rd, 2012, 4:26 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2012, 4:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opaquifiy the ast_channel structs by just adding a getter function that returns the pointer. That pointer can then be used with the ast_format APIs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles and the unit tests run successfully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/chan_mobile.c <span style="color: grey">(356474)</span></li>
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_amd.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_chanspy.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_confbridge.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_dictate.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_dumpchan.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_fax.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_festival.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_ices.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_meetme.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_mp3.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_nbscat.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_record.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_speech_utils.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_talkdetect.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_test.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(356474)</span></li>
<li>/trunk/apps/app_waitforsilence.c <span style="color: grey">(356474)</span></li>
<li>/trunk/bridges/bridge_multiplexed.c <span style="color: grey">(356474)</span></li>
<li>/trunk/bridges/bridge_simple.c <span style="color: grey">(356474)</span></li>
<li>/trunk/bridges/bridge_softmix.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_agent.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_alsa.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_bridge.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_console.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_mgcp.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_misdn.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_multicast_rtp.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_nbs.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_oss.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_phone.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_usbradio.c <span style="color: grey">(356474)</span></li>
<li>/trunk/channels/chan_vpb.cc <span style="color: grey">(356474)</span></li>
<li>/trunk/funcs/func_channel.c <span style="color: grey">(356474)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(356474)</span></li>
<li>/trunk/main/app.c <span style="color: grey">(356474)</span></li>
<li>/trunk/main/bridging.c <span style="color: grey">(356474)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(356474)</span></li>
<li>/trunk/main/channel_internal_api.c <span style="color: grey">(356474)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(356474)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(356474)</span></li>
<li>/trunk/main/file.c <span style="color: grey">(356474)</span></li>
<li>/trunk/main/indications.c <span style="color: grey">(356474)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(356474)</span></li>
<li>/trunk/main/rtp_engine.c <span style="color: grey">(356474)</span></li>
<li>/trunk/res/res_adsi.c <span style="color: grey">(356474)</span></li>
<li>/trunk/res/res_agi.c <span style="color: grey">(356474)</span></li>
<li>/trunk/res/res_calendar.c <span style="color: grey">(356474)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(356474)</span></li>
<li>/trunk/res/res_musiconhold.c <span style="color: grey">(356474)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1770/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>