<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1761/">https://reviewboard.asterisk.org/r/1761/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 22nd, 2012, 12:34 p.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only made it 1/2 through, but same comments apply. I see a lot of duplicate code in the runtest.py, any chance of moving the code to another class we can share?
It will help the maintainers.
Also, we should avoid using Wait(10), or any other number in dialplan logic. We cannot be sure a system running the test will have enough time to run the code. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed for connected line and redirecting tests only. The CCSS test still needs some love.</pre>
<br />
<p>- opticron</p>
<br />
<p>On February 21st, 2012, 7:48 p.m., opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2012, 7:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add tests for the existing macro and new gosub calls in relation to connected line, redirecting, and ccss.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SWP-4254">SWP-4254</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: grey">(3036)</span></li>
<li>asterisk/trunk/tests/connected_line/macro/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/macro/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/macro/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/subroutine/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/subroutine/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/subroutine/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/macro/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/macro/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/macro/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/subroutine/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/subroutine/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/subroutine/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/tests.yaml <span style="color: grey">(3036)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1761/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>