<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1730/">https://reviewboard.asterisk.org/r/1730/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good.</pre>
<br />
<p>- Joshua</p>
<br />
<p>On February 9th, 2012, 7:10 p.m., rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2012, 7:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using SIP blind transfer to a custom parking lot access extension plays the parking slot to the parked call.
The BLINDTRANSFER channel variable was not being used correctly to determine the parking channel name.
BLINDTRANSFER is set by features DTMF, SIP, and IAX when the blind transfer methods are invoked.
This patch also fixes the ability of timedout parked calls to use the correct channel to callback the parker.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Parked a call with a custom parking lot access extension dialplan where the Park application is not the first priority of the extension.
exten => 600,1,Park()
exten => 700,1,NoOp()
exten => 700,n,Park()
exten => 800,1,NoOp()
exten => 800,n,ParkAndAnnounce(something appropriate was put here)
The initial call was made to and from the transferer.
SIP blind transfered to the 600 and 700 extension call.
SIP attended transfered to the 600 and 700 extension.
SIP blind transfered to the 800 extension.
SIP attended transfered to the 800 extension does not work and likely is not a valid scenario anyway. It is outside the scope of this patch anyway.
Now works as expected for the tested scenarios.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/AST-766">AST-766</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19322">ASTERISK-19322</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(354798)</span></li>
<li>/branches/1.8/main/features.c <span style="color: grey">(354798)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1730/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>