<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1753/">https://reviewboard.asterisk.org/r/1753/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 21st, 2012, 8:33 a.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This introduces several issues building in dev mode.</pre>
</blockquote>
<p>On February 21st, 2012, 10:16 a.m., <b>Terry Wilson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am assuming you are using an older compiler, because it compiles fine in dev mode for me. Could you be a little more specific about the issues you see?</pre>
</blockquote>
<p>On February 21st, 2012, 10:59 a.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm on gcc 4.6.3. This is the first of them:
res_monitor.c: In function 'start_monitor_exec':
res_monitor.c:696:22: error: 'chan_cdr' may be used uninitialized in this function [-Werror=uninitialized]
There are also issues that pop up in channel.c and elsewhere.</pre>
</blockquote>
<p>On February 21st, 2012, 11:26 a.m., <b>Terry Wilson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm using gcc 4.6.1 and it doesn't complain. The one you point out looks like a valid issue; if the channel cdr is already set, we would overwrite it with a unitialized value. I think moving the set into an else block would be the thing to do. But I can't fix them if I don't know where they are. Is gcc 4.6.3 the snapshot? I don't see a 4.6.3 release. Please create an issue with the compiler output and I'll see what I can do. I just can't fix what I can't see. :-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Posted in ASTERISK-19419</pre>
<br />
<p>- opticron</p>
<br />
<p>On February 18th, 2012, 1:45 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2012, 1:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This converts various int/long fields and most pointer fields. That leaves mostly structs, typedefs, a couple of int arrays and a couple of "problem fields". It might be a good idea for reviewers to apply the patch and compile just in case I missed something somewhere.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All unit tests pass. I got the same number of testsuite failures as a clean checkout of trunk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/chan_mobile.c <span style="color: grey">(355898)</span></li>
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_alarmreceiver.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_authenticate.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_cdr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_chanisavail.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_channelredirect.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_chanspy.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_confbridge.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dahdibarge.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dahdiras.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dial.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dictate.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_directory.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_disa.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dumpchan.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_echo.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_externalivr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_fax.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_festival.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_flash.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_followme.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_forkcdr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_ices.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_ivrdemo.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_macro.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_meetme.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_milliwatt.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_minivm.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_osplookup.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_parkandannounce.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_playback.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_playtones.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_privacy.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_queue.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_read.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_readexten.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_record.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_rpt.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_sayunixtime.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_sendtext.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_sms.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_softhangup.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_speech_utils.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_stack.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_talkdetect.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_test.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_transfer.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_verbose.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_waitforsilence.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_while.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_zapateller.c <span style="color: grey">(355898)</span></li>
<li>/trunk/bridges/bridge_builtin_features.c <span style="color: grey">(355898)</span></li>
<li>/trunk/bridges/bridge_multiplexed.c <span style="color: grey">(355898)</span></li>
<li>/trunk/bridges/bridge_simple.c <span style="color: grey">(355898)</span></li>
<li>/trunk/cdr/cdr_custom.c <span style="color: grey">(355898)</span></li>
<li>/trunk/cdr/cdr_manager.c <span style="color: grey">(355898)</span></li>
<li>/trunk/cdr/cdr_sqlite3_custom.c <span style="color: grey">(355898)</span></li>
<li>/trunk/cdr/cdr_syslog.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_agent.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_alsa.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_bridge.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_console.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_mgcp.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_misdn.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_multicast_rtp.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_nbs.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_oss.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_phone.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_usbradio.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_vpb.cc <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/sig_pri.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/sig_ss7.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/sip/dialplan_functions.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_callerid.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_cdr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_channel.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_jitterbuffer.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_timeout.c <span style="color: grey">(355898)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(355898)</span></li>
<li>/trunk/include/asterisk/sched.h <span style="color: grey">(355898)</span></li>
<li>/trunk/main/abstract_jb.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/app.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/audiohook.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/bridging.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/ccss.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/cdr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/cel.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/channel_internal_api.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/devicestate.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/dial.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/file.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/framehook.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/image.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/message.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/rtp_engine.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/udptl.c <span style="color: grey">(355898)</span></li>
<li>/trunk/pbx/pbx_lua.c <span style="color: grey">(355898)</span></li>
<li>/trunk/pbx/pbx_realtime.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_adsi.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_agi.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_calendar.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_monitor.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_musiconhold.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_rtp_asterisk.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/snmp/agent.c <span style="color: grey">(355898)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1753/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>