<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1753/">https://reviewboard.asterisk.org/r/1753/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From what I saw, I did not see any issues that prevent this from going in.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1753/diff/1/?file=24343#file24343line523" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/apps/app_followme.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void clear_caller(struct findme_user *tmpuser)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">523</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">523</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n"><span class="hl">ast_channel_cdr</span></span><span class="p"><span class="hl">(</span></span><span class="n">outbound</span><span class="p"><span class="hl">)</span>)</span> <span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">524</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span> <span class="n">ast_cdr_alloc</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">524</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">ast_channel_cdr_set</span></span><span class="p"><span class="hl">(</span></span><span class="n">outbound</span><span class="p"><span class="hl">,</span></span> <span class="n">ast_cdr_alloc</span><span class="p">()<span class="hl">)</span>;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">525</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">525</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">ast_channel_cdr</span></span><span class="p">(</span><span class="n">outbound</span><span class="p"><span class="hl">)</span>)</span> <span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">526</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_init</span><span class="p">(</span><span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="p">,</span> <span class="n">outbound</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">526</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_init</span><span class="p">(</span><span class="n"><span class="hl">ast_channel_cdr</span></span><span class="p"><span class="hl">(</span></span><span class="n">outbound</span><span class="p"><span class="hl">)</span>,</span> <span class="n">outbound</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">527</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">527</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">528</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">528</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">529</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">529</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">ast_channel_cdr</span></span><span class="p">(</span><span class="n">outbound</span><span class="p"><span class="hl">)</span>)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">530</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">char</span> <span class="n">tmp</span><span class="p">[</span><span class="mi">256</span><span class="p">];</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">530</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">char</span> <span class="n">tmp</span><span class="p">[</span><span class="mi">256</span><span class="p">];</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">531</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">531</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">532</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">snprintf</span><span class="p">(</span><span class="n">tmp</span><span class="p">,</span> <span class="k">sizeof</span><span class="p">(</span><span class="n">tmp</span><span class="p">),</span> <span class="s">"%s/%s"</span><span class="p">,</span> <span class="s">"Local"</span><span class="p">,</span> <span class="n">tmpuser</span><span class="o">-></span><span class="n">dialarg</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">532</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">snprintf</span><span class="p">(</span><span class="n">tmp</span><span class="p">,</span> <span class="k">sizeof</span><span class="p">(</span><span class="n">tmp</span><span class="p">),</span> <span class="s">"%s/%s"</span><span class="p">,</span> <span class="s">"Local"</span><span class="p">,</span> <span class="n">tmpuser</span><span class="o">-></span><span class="n">dialarg</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">533</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_setapp</span><span class="p">(</span><span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="p">,</span> <span class="s">"FollowMe"</span><span class="p">,</span> <span class="n">tmp</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">533</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_setapp</span><span class="p">(</span><span class="n"><span class="hl">ast_channel_cdr</span></span><span class="p"><span class="hl">(</span></span><span class="n">outbound</span><span class="p"><span class="hl">)</span>,</span> <span class="s">"FollowMe"</span><span class="p">,</span> <span class="n">tmp</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">534</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_update</span><span class="p">(</span><span class="n">outbound</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">534</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_update</span><span class="p">(</span><span class="n">outbound</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">535</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_start</span><span class="p">(</span><span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">535</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_start</span><span class="p">(</span><span class="n"><span class="hl">ast_channel_cdr</span></span><span class="p"><span class="hl">(</span></span><span class="n">outbound</span><span class="p"><span class="hl">)</span>);</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">536</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_end</span><span class="p">(</span><span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">536</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_end</span><span class="p">(</span><span class="n"><span class="hl">ast_channel_cdr</span></span><span class="p"><span class="hl">(</span></span><span class="n">outbound</span><span class="p"><span class="hl">)</span>);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">537</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cm">/* If the cause wasn't handled properly */</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">537</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cm">/* If the cause wasn't handled properly */</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">538</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">ast_cdr_disposition</span><span class="p">(</span><span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">outbound</span></span><span class="o"><span class="hl">-></span></span><span class="n">hangupcause</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">538</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">ast_cdr_disposition</span><span class="p">(</span><span class="n"><span class="hl">ast_channel_cdr</span></span><span class="p"><span class="hl">(</span></span><span class="n">outbound</span><span class="p"><span class="hl">),</span></span><span class="hl"> </span><span class="n"><span class="hl">ast_channel_</span>hangupcause</span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">outbound</span></span><span class="p"><span class="hl">)</span>))</span> <span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">539</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_failed</span><span class="p">(</span><span class="n">outbound</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">cdr</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">539</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cdr_failed</span><span class="p">(</span><span class="n"><span class="hl">ast_channel_cdr</span></span><span class="p"><span class="hl">(</span></span><span class="n">outbound</span><span class="p"><span class="hl">)</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As you come across passages like these, it may be worthwhile to add some comments to indicate that this should be looked at again once the opaquification is completed. The reason is that there are a lot of calls to ast_channel_cdr() here, and it may be possible to call it once and set a local variable, then just use the local variable for the rest of the section.
Please don't make such actual changes now, but "todo"-style comments are welcome.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1753/diff/1/?file=24412#file24412line3649" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/include/asterisk/channel.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ast_channel_context_set(struct ast_channel *chan, const char *value);</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3649</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">char</span> <span class="n">ast_channel_emulate_dtmf_digit</span><span class="p">(</span><span class="k">const</span> <span class="k">struct</span> <span class="n">ast_channel</span> <span class="o">*</span><span class="n">chan</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3650</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">ast_channel_emulate_dtmf_digit_set</span><span class="p">(</span><span class="k">struct</span> <span class="n">ast_channel</span> <span class="o">*</span><span class="n">chan</span><span class="p">,</span> <span class="kt">char</span> <span class="n">value</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If at all possible, I'd rename these two functions. The accessor sounds like something you would call in order to emulate a DTMF digit. The setter just sounds like nonsense.</pre>
</div>
<br />
<p>- Mark</p>
<br />
<p>On February 18th, 2012, 1:45 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2012, 1:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This converts various int/long fields and most pointer fields. That leaves mostly structs, typedefs, a couple of int arrays and a couple of "problem fields". It might be a good idea for reviewers to apply the patch and compile just in case I missed something somewhere.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All unit tests pass. I got the same number of testsuite failures as a clean checkout of trunk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/chan_mobile.c <span style="color: grey">(355898)</span></li>
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_alarmreceiver.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_authenticate.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_cdr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_chanisavail.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_channelredirect.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_chanspy.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_confbridge.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dahdibarge.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dahdiras.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dial.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dictate.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_directory.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_disa.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_dumpchan.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_echo.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_externalivr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_fax.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_festival.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_flash.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_followme.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_forkcdr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_ices.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_ivrdemo.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_macro.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_meetme.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_milliwatt.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_minivm.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_osplookup.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_parkandannounce.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_playback.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_playtones.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_privacy.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_queue.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_read.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_readexten.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_record.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_rpt.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_sayunixtime.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_sendtext.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_sms.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_softhangup.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_speech_utils.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_stack.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_talkdetect.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_test.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_transfer.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_verbose.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_waitforsilence.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_while.c <span style="color: grey">(355898)</span></li>
<li>/trunk/apps/app_zapateller.c <span style="color: grey">(355898)</span></li>
<li>/trunk/bridges/bridge_builtin_features.c <span style="color: grey">(355898)</span></li>
<li>/trunk/bridges/bridge_multiplexed.c <span style="color: grey">(355898)</span></li>
<li>/trunk/bridges/bridge_simple.c <span style="color: grey">(355898)</span></li>
<li>/trunk/cdr/cdr_custom.c <span style="color: grey">(355898)</span></li>
<li>/trunk/cdr/cdr_manager.c <span style="color: grey">(355898)</span></li>
<li>/trunk/cdr/cdr_sqlite3_custom.c <span style="color: grey">(355898)</span></li>
<li>/trunk/cdr/cdr_syslog.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_agent.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_alsa.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_bridge.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_console.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_mgcp.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_misdn.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_multicast_rtp.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_nbs.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_oss.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_phone.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_usbradio.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/chan_vpb.cc <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/sig_pri.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/sig_ss7.c <span style="color: grey">(355898)</span></li>
<li>/trunk/channels/sip/dialplan_functions.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_callerid.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_cdr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_channel.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_jitterbuffer.c <span style="color: grey">(355898)</span></li>
<li>/trunk/funcs/func_timeout.c <span style="color: grey">(355898)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(355898)</span></li>
<li>/trunk/include/asterisk/sched.h <span style="color: grey">(355898)</span></li>
<li>/trunk/main/abstract_jb.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/app.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/audiohook.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/bridging.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/ccss.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/cdr.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/cel.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/channel_internal_api.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/devicestate.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/dial.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/file.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/framehook.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/image.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/message.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/rtp_engine.c <span style="color: grey">(355898)</span></li>
<li>/trunk/main/udptl.c <span style="color: grey">(355898)</span></li>
<li>/trunk/pbx/pbx_lua.c <span style="color: grey">(355898)</span></li>
<li>/trunk/pbx/pbx_realtime.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_adsi.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_agi.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_calendar.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_monitor.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_musiconhold.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/res_rtp_asterisk.c <span style="color: grey">(355898)</span></li>
<li>/trunk/res/snmp/agent.c <span style="color: grey">(355898)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1753/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>