<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1653/">https://reviewboard.asterisk.org/r/1653/</a>
     </td>
    </tr>
   </table>
   <br />








<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On January 18th, 2012, 4:54 a.m., <b>wdoekes</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/1653/diff/5/?file=23411#file23411line1097" style="color: black; font-weight: bold; text-decoration: underline;">trunk/mtp3.c</a>
    <span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void mtp3_forced_reroute(struct adjacent_sp *adj_sp, struct mtp3_route *route)</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1082</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">winner</span><span class="p">)</span> <span class="p">{</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1091</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">winner</span> <span class="o">&amp;&amp;</span> <span class="o">*</span><span class="n">headerptr</span> <span class="o">!=</span> <span class="p">(</span><span class="n">NET_MNG_TRA</span><span class="p">)</span> <span class="o">&amp;&amp;</span> <span class="o">*</span><span class="n">headerptr</span> <span class="o">!=</span> <span class="p">(</span><span class="n">NET_MNG_TFA</span><span class="p">)</span> <span class="o">&amp;&amp;</span> <span class="o">*</span><span class="n">headerptr</span> <span class="o">!=</span> <span class="p">(</span><span class="n">NET_MNG_TFP</span><span class="p">)</span> <span class="o">&amp;&amp;</span> <span class="o">*</span><span class="n">headerptr</span> <span class="o">!=</span> <span class="p">(</span><span class="n">NET_MNG_TFR</span><span class="p">))</span> <span class="p">{</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are the parentheses around NET_* needed?</pre>
 </blockquote>



 <p>On January 18th, 2012, 8:26 a.m., <b>KNK</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, as it is defined as 0x07 | 0x10 (so are all other NET_MNG_XXX messages)</pre>
 </blockquote>







</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Then those defines should be fixed to add the necessary insulating parentheses to avoid potential future surprises.  Otherwise that code looks odd.</pre>
<br />




<p>- rmudgett</p>


<br />
<p>On January 19th, 2012, 5:21 a.m., KNK wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By KNK.</div>


<p style="color: grey;"><i>Updated Jan. 19, 2012, 5:21 a.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">libss7 part of the changes only</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, link setup, cli commands, bassic calls</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/SS7-27">SS7-27</a>, 

 <a href="https://issues.asterisk.org/jira/browse/SS7-52">SS7-52</a>, 

 <a href="https://issues.asterisk.org/jira/browse/SS7-53">SS7-53</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/ss7.c <span style="color: grey">(296)</span></li>

 <li>trunk/libss7.h <span style="color: grey">(296)</span></li>

 <li>trunk/mtp2.h <span style="color: grey">(296)</span></li>

 <li>trunk/mtp2.c <span style="color: grey">(296)</span></li>

 <li>trunk/mtp3.h <span style="color: grey">(296)</span></li>

 <li>trunk/mtp3.c <span style="color: grey">(296)</span></li>

 <li>trunk/isup.h <span style="color: grey">(296)</span></li>

 <li>trunk/isup.c <span style="color: grey">(296)</span></li>

 <li>trunk/ss7_internal.h <span style="color: grey">(296)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1653/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>