<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1740/">https://reviewboard.asterisk.org/r/1740/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By a_villacis.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2012, 11:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added link to JIRA issue.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was found while trying to isolate a deadlock on FreePBX "Apply Changes" reload in our PBX. Looks to me like a simple-to-fix typo.
[root@pbx tmp]# asterisk -rnx 'core show locks'
=======================================================================
=== Currently Held Locks ==============================================
=======================================================================
===
=== <pending> <lock#> (<file>): <lock type> <line num> <function> <lock name> <lock addr> (times locked)
===
=== Thread ID: 0x4064a940 (tps_processing_function started at [ 451] taskprocessor.c ast_taskprocessor_get())
=== ---> Lock #0 (event.c): RDLOCK 1452 handle_event &(&ast_event_subs[event_types[i]])->lock 0x8348d8 (1)
/usr/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4f2390]
/usr/sbin/asterisk(__ast_rwlock_rdlock+0xf6) [0x4eceae]
/usr/sbin/asterisk [0x4b65f4]
/usr/sbin/asterisk [0x564c5e]
/usr/sbin/asterisk [0x577618]
/lib64/libpthread.so.0 [0x3be5a0673d]
/lib64/libc.so.6(clone+0x6d) [0x3be4ed44bd]
=== ---> Waiting for Lock #1 (cel_sqlite3_custom.c): MUTEX 241 write_cel &lock 0x2aaac7751380 (1)
/usr/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4f2390]
/usr/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4eac91]
/usr/lib64/asterisk/modules/cel_sqlite3_custom.so [0x2aaac754fbf9]
/usr/sbin/asterisk [0x4b667b]
/usr/sbin/asterisk [0x564c5e]
/usr/sbin/asterisk [0x577618]
/lib64/libpthread.so.0 [0x3be5a0673d]
/lib64/libc.so.6(clone+0x6d) [0x3be4ed44bd]
=== --- ---> Locked Here: cel_sqlite3_custom.c line 354 (reload)
=== --- ---> Locked Here: cel_sqlite3_custom.c line 356 (reload)
=== -------------------------------------------------------------------
===
=======================================================================
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19356">ASTERISK-19356</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/cel/cel_sqlite3_custom.c <span style="color: grey">(355276)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1740/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>