<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1651/">https://reviewboard.asterisk.org/r/1651/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2012, 2:07 p.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pretty please, commit the thing already.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">wdoekes: feel free to commit it yourself. You've done a lot of the review for it. I would commit it, but I haven't even looked at the patch. It seems better that someone who has had input into it should commit it.</pre>
<br />
<p>- Terry</p>
<br />
<p>On January 27th, 2012, 7:54 p.m., junky wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By junky.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2012, 7:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">By running cppcheck 1.52, i realized there was many errors/warnings.
This patch fixes many of those.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">still compile fine.
Shouldn't have any impact on the code execution.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/addons/chan_mobile.c <span style="color: grey">(352913)</span></li>
<li>trunk/addons/chan_ooh323.c <span style="color: grey">(352913)</span></li>
<li>trunk/apps/app_alarmreceiver.c <span style="color: grey">(351181)</span></li>
<li>trunk/apps/app_chanspy.c <span style="color: grey">(352913)</span></li>
<li>trunk/apps/app_dial.c <span style="color: grey">(352913)</span></li>
<li>trunk/apps/app_disa.c <span style="color: grey">(352913)</span></li>
<li>trunk/apps/app_minivm.c <span style="color: grey">(352913)</span></li>
<li>trunk/apps/app_osplookup.c <span style="color: grey">(351181)</span></li>
<li>trunk/apps/app_queue.c <span style="color: grey">(352913)</span></li>
<li>trunk/apps/app_voicemail.c <span style="color: grey">(352913)</span></li>
<li>trunk/channels/chan_dahdi.c <span style="color: grey">(352913)</span></li>
<li>trunk/channels/chan_iax2.c <span style="color: grey">(352913)</span></li>
<li>trunk/channels/chan_misdn.c <span style="color: grey">(352913)</span></li>
<li>trunk/channels/chan_skinny.c <span style="color: grey">(352913)</span></li>
<li>trunk/channels/chan_usbradio.c <span style="color: grey">(352913)</span></li>
<li>trunk/formats/format_h263.c <span style="color: grey">(351181)</span></li>
<li>trunk/funcs/func_env.c <span style="color: grey">(351181)</span></li>
<li>trunk/funcs/func_odbc.c <span style="color: grey">(352913)</span></li>
<li>trunk/funcs/func_strings.c <span style="color: grey">(351181)</span></li>
<li>trunk/main/acl.c <span style="color: grey">(352913)</span></li>
<li>trunk/main/ast_expr2.fl <span style="color: grey">(352913)</span></li>
<li>trunk/main/ast_expr2f.c <span style="color: grey">(352913)</span></li>
<li>trunk/main/pbx.c <span style="color: grey">(352913)</span></li>
<li>trunk/main/udptl.c <span style="color: grey">(352913)</span></li>
<li>trunk/utils/astman.c <span style="color: grey">(351181)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1651/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>