<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1528/">https://reviewboard.asterisk.org/r/1528/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 20th, 2011, 3:59 a.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pauls issue still isn't addressed:
pkg-config --cflags returns nada because <editline/readline.h> is accessible (through the normal /usr/include).
$ grep includedir /usr/lib/pkgconfig/libedit.pc
includedir=${prefix}/include
Cflags: -I${includedir}
$ pkg-config libedit --cflags
(empty)
$ grep LIBEDIT makeopts
LIBEDIT_INCLUDE=
LIBEDIT_LIB=-ledit -lcurses
LIBEDIT_OBJ=
make[1]: Entering directory `/home/walter/src/asterisk-svn/main'
gcc -o cli.o -c cli.c -MD -MT cli.o -MF .cli.o.d -MP -pthread -I/home/walter/src/asterisk-svn/include -I/usr/include/libxml2 -pipe -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -g3 -march=native -O0 -DAST_MODULE=\"core\"
cli.c:39:22: error: readline.h: No such file or directory</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ping? Are you able to upload a new patch?</pre>
<br />
<p>- Paul</p>
<br />
<p>On October 18th, 2011, 8:09 a.m., jcollie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Russell Bryant.</div>
<div>By jcollie.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2011, 8:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Asterisk tarball includes a very old copy of the editline library
that manages command line history and editing. Fedora (and several
other distributions) highly discourage this practice because if there
are security problems (or even just severe bugs) in the library it can
be very difficult to track down all instances of the library. This
patch adds the option of building/linking against an external copy of
the editline library.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch has been in use in the Fedora Asterisk packages for some time now. Cleaning up and submitting for review. Has been compiled and CLI editing and recall works as it's supposed to.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18725">ASTERISK-18725</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/build_tools/menuselect-deps.in <span style="color: grey">(341072)</span></li>
<li>/trunk/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/trunk/configure.ac <span style="color: grey">(341072)</span></li>
<li>/trunk/include/asterisk/autoconfig.h.in <span style="color: grey">(341072)</span></li>
<li>/trunk/main/Makefile <span style="color: grey">(341072)</span></li>
<li>/trunk/main/asterisk.c <span style="color: grey">(341072)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(341072)</span></li>
<li>/trunk/makeopts.in <span style="color: grey">(341072)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1528/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>