<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1692/">https://reviewboard.asterisk.org/r/1692/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 26th, 2012, 12:04 a.m., <b>junky</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just for tracability: https://issues.asterisk.org/jira/browse/ASTERISK-16903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
why did you move write_cleanup: ?
if you cant allocate memory, you'll try to allocate again (which will probably fails too) when calling pbx_builtin_setvar_helper(chan, "CALENDARSTATUS" 0/1.</pre>
</blockquote>
<p>On January 26th, 2012, 7:26 a.m., <b>Terry Wilson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I moved write_cleanup because memory allocations would result in CALENDAR_SUCCESS not being set at all. I don't see anywhere where there is another attempted allocation, but I do use those allocations. I need to move the ret = ... and ast_log lines above the write_cleanup, but keep the setvars under it. Also, the bug is linked above under Bugs: :-)</pre>
</blockquote>
<p>On January 26th, 2012, 7:31 a.m., <b>Terry Wilson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Er, memory allocation failures would result in the variable not being set, and I attempt to use possibly-failed allocations.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Er, I actually mean any error would cause the variable to not be set. I don't function well in the morning.</pre>
<br />
<p>- Terry</p>
<br />
<p>On January 26th, 2012, 7:33 a.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and junky.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2012, 7:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a CALENDAR_SUCCESS=1/0 variable that is set to show whether or not CALENDAR_WRITE has passed. This patch is basically junky's patch from the issue with CALENDAR_SUCCESS=1/0 instead of CALENDARSTATUS="SUCCESS"/"FAILURE" so that one can just do GotoIf(${CALENDAR_SUCCESS}?success:failure). Also changed is adding some debugging for caldav PUT responses and not treating responses with no body as an error (as a PUT gets a 201 Created with no body).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wrote to a caldav calendar and verified proper creation of event and CALENDAR_SUCCESS values.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-16903">ASTERISK-16903</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_calendar.c <span style="color: grey">(352510)</span></li>
<li>/trunk/res/res_calendar_caldav.c <span style="color: grey">(352510)</span></li>
<li>/trunk/res/res_calendar_exchange.c <span style="color: grey">(352510)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1692/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>