<html>

 <body>

  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">

   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">

    <tr>

     <td>

      This is an automatically generated e-mail. To reply, visit:

      <a href="https://reviewboard.asterisk.org/r/1671/">https://reviewboard.asterisk.org/r/1671/</a>

     </td>

    </tr>

   </table>

   <br />

 <p>Ship it!</p>

<p>- Paul</p>

<br />

<p>On January 22nd, 2012, 1:58 p.m., wdoekes wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">

 <tr>

  <td>

<div>Review request for Asterisk Developers.</div>

<div>By wdoekes.</div>

<p style="color: grey;"><i>Updated Jan. 22, 2012, 1:58 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>

<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">

 <tr>

  <td>

   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Most CDR test cases simply waited for the reactor timeout to fire. Only the tests that had a failing call were terminated in a timely fashion.

Add a check for the Hangup and count 0 active channels.</pre>

  </td>

 </tr>

</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>

<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">

 <tr>

  <td>

   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">5 out of 8 CDR tests run faster now.

Before:

--&gt; Running test &#39;tests/cdr/console_dial_sip_busy&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;3.40&quot;&gt;

--&gt; Cannot run test &#39;tests/cdr/console_dial_sip_transfer&#39;

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;0&quot; time=&quot;0.00&quot;/&gt;

--&gt; Running test &#39;tests/cdr/console_dial_sip_answer&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;33.28&quot;&gt;

--&gt; Running test &#39;tests/cdr/cdr_unanswered_yes&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;3.60&quot;&gt;

--&gt; Running test &#39;tests/cdr/console_dial_sip_congestion&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;3.44&quot;&gt;

--&gt; Running test &#39;tests/cdr/console_fork_after_busy_forward&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;33.25&quot;&gt;

--&gt; Cannot run test &#39;tests/cdr/cdr_originate_sip_congestion_log&#39;

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;0&quot; time=&quot;0.00&quot;/&gt;

--&gt; Running test &#39;tests/cdr/console_fork_before_dial&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;33.21&quot;&gt;

--&gt; Running test &#39;tests/cdr/cdr_userfield&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;33.21&quot;&gt;

--&gt; Running test &#39;tests/cdr/nocdr&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;33.21&quot;&gt;

After:

--&gt; Running test &#39;tests/cdr/console_dial_sip_busy&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;4.55&quot;&gt;

--&gt; Cannot run test &#39;tests/cdr/console_dial_sip_transfer&#39;

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;0&quot; time=&quot;0.00&quot;/&gt;

--&gt; Running test &#39;tests/cdr/console_dial_sip_answer&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;4.26&quot;&gt;

--&gt; Running test &#39;tests/cdr/cdr_unanswered_yes&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;3.62&quot;&gt;

--&gt; Running test &#39;tests/cdr/console_dial_sip_congestion&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;5.10&quot;&gt;

--&gt; Running test &#39;tests/cdr/console_fork_after_busy_forward&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;5.05&quot;&gt;

--&gt; Cannot run test &#39;tests/cdr/cdr_originate_sip_congestion_log&#39;

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;0&quot; time=&quot;0.00&quot;/&gt;

--&gt; Running test &#39;tests/cdr/console_fork_before_dial&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;7.78&quot;&gt;

--&gt; Running test &#39;tests/cdr/cdr_userfield&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;4.06&quot;&gt;

--&gt; Running test &#39;tests/cdr/nocdr&#39; ...

&lt;testsuite errors=&quot;0&quot; failures=&quot;0&quot; name=&quot;AsteriskTestSuite&quot; tests=&quot;1&quot; time=&quot;3.95&quot;&gt;</pre>

  </td>

 </tr>

</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>

<ul style="margin-left: 3em; padding-left: 0;">

 <li>asterisk/trunk/lib/python/asterisk/CDRTestCase.py <span style="color: grey">(2991)</span></li>

 <li>asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(2991)</span></li>

 <li>asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(2991)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_answer/run-test <span style="color: grey">(2991)</span></li>

 <li>asterisk/trunk/tests/cdr/console_dial_sip_busy/run-test <span style="color: grey">(2991)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1671/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>

 </tr>

</table>

  </div>

 </body>

</html>