<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1683/">https://reviewboard.asterisk.org/r/1683/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me!</pre>
<br />
<p>- Mark</p>
<br />
<p>On January 20th, 2012, 8:09 p.m., rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2012, 8:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes done by this patch:
* Expand SIP short header names so the dialplan and other code only has to deal with the full names.
* Fix authenticate MESSAGE losing custom headers added by the MESSAGE_DATA function in the authorization attempt.
* Block user from adding standard headers that are added automatically. (To, From,...)
* Pass up better From header contents for SIP to use. Now is in the "display-name" <URI> format expected by MessageSend.
(Note that this is a behavior change that could concievably affect some people.)
* Decrement Max-Forwards header if the user transferred it from an incoming message.
* Allow the user to override the Content-Type header contents sent by MessageSend.
* Documents what SIP expects in the MessageSend(from) parameter.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated SIP MESSAGE external tests with more cases that cover some of the items fixed. The tests pass.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18917">ASTERISK-18917</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18992">ASTERISK-18992</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19058">ASTERISK-19058</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/10/channels/chan_sip.c <span style="color: grey">(352088)</span></li>
<li>/branches/10/channels/sip/include/sip.h <span style="color: grey">(352088)</span></li>
<li>/branches/10/main/message.c <span style="color: grey">(352088)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1683/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>