<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1654/">https://reviewboard.asterisk.org/r/1654/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great work!</pre>
<br />
<p>- David</p>
<br />
<p>On January 5th, 2012, 6:31 p.m., Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson and David Vossel.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2012, 6:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addresses two issues in ConfBridge and the channel bridge layer:
1. It fixes a race condition wherein the bridge channel could be hung up twice
2. It removes the deadlock avoidance from the bridging layer and makes the bridge_pvt an ao2 ref counted object
Note that this is a David Vossel patch, and I make no claim to its awesomeness.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Previously ConfBridge would suffer timing-dependent crashes on application exit. This usually occurred one out of every 20 or so runs (using the Test Suite's ConfBridge nominal test).
With the patch, ran 100 times without failures.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18885">ASTERISK-18885</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18988">ASTERISK-18988</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19100">ASTERISK-19100</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/10/apps/app_confbridge.c <span style="color: grey">(349721)</span></li>
<li>/branches/10/bridges/bridge_builtin_features.c <span style="color: grey">(349721)</span></li>
<li>/branches/10/channels/chan_bridge.c <span style="color: grey">(349721)</span></li>
<li>/branches/10/include/asterisk/bridging.h <span style="color: grey">(349721)</span></li>
<li>/branches/10/main/bridging.c <span style="color: grey">(349721)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1654/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>