<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1662/">https://reviewboard.asterisk.org/r/1662/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's more moving stuff around than I normally like to do for this kind of thing in a release branch, but it fixes the issue, makes things more readable, and I haven't been able to break it. One thing to note is that previous versions would let you run "core stop when convenient" after running "core stop gracefully" as though it would work, but it really didn't because the channel.c stuff didn't get reset. So this makes the behavior cleaner even in that case.</pre>
<br />
<p>- Terry</p>
<br />
<p>On January 10th, 2012, 3:16 p.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Terry Wilson.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2012, 3:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A more elaborate attempt at fixing issues with multiple calls to quit_handler; see https://reviewboard.asterisk.org/r/1658/
With this patch, niceness is allowed to be decreased: if you did a 'core stop gracefully' you can decrease the niceness with a 'core stop now', but not the other way around. 'core abort shutdown' is still allowed *until* the safe-shutdown part of the code has been reached.
It kind of grew larger -- and therefore less pretty -- than I had hoped unfortunately.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a bit of sleep can_safely_quit so I could test it. Seemed to work ok.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/1.8/main/asterisk.c <span style="color: grey">(350307)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1662/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>