<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1661/">https://reviewboard.asterisk.org/r/1661/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch converts the rest of the stringfields to setters/getters. Interesting changes are in channel.h and channel_internal_api.c, where I use some horrible macros to generate setter declarations and definitions to avoid having to write 3 different setter functions for each string field (set, build, and build_va). Wrapping stringfields that are inside a struct that is going to be opaque is kind of a pain since we have to pass the field name to the stringfield macros. I'm not completely convinced that the macros are the way to go, but they do certainly use a lot less space. I'm also not sure the best way to handle doxygen comments for such things...just comment the macros for the declarations, or where we call the macros... Opinions?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran the testsuite.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/app_saycountpl.c <span style="color: grey">(350231)</span></li>
<li>/trunk/addons/chan_mobile.c <span style="color: grey">(350231)</span></li>
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_authenticate.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_chanspy.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_confbridge.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_dial.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_dictate.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_directory.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_disa.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_dumpchan.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_externalivr.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_followme.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_meetme.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_minivm.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_page.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_parkandannounce.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_playback.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_privacy.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_queue.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_readexten.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_record.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_rpt.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_sayunixtime.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_speech_utils.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_stack.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_talkdetect.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_userevent.c <span style="color: grey">(350231)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_agent.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_alsa.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_bridge.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_console.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_mgcp.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_misdn.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_multicast_rtp.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_nbs.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_oss.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_phone.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/chan_usbradio.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(350231)</span></li>
<li>/trunk/channels/sig_pri.c <span style="color: grey">(350231)</span></li>
<li>/trunk/funcs/func_channel.c <span style="color: grey">(350231)</span></li>
<li>/trunk/funcs/func_global.c <span style="color: grey">(350231)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(350231)</span></li>
<li>/trunk/main/aoc.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/app.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/cdr.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/cel.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/channel_internal_api.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/dial.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/file.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/image.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(350231)</span></li>
<li>/trunk/main/say.c <span style="color: grey">(350231)</span></li>
<li>/trunk/pbx/pbx_realtime.c <span style="color: grey">(350231)</span></li>
<li>/trunk/res/res_agi.c <span style="color: grey">(350231)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(350231)</span></li>
<li>/trunk/res/res_monitor.c <span style="color: grey">(350231)</span></li>
<li>/trunk/res/res_musiconhold.c <span style="color: grey">(350231)</span></li>
<li>/trunk/res/snmp/agent.c <span style="color: grey">(350231)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1661/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>