<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1659/">https://reviewboard.asterisk.org/r/1659/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While this is a patch that needs to go in, it only fixes one possible cause of the issue. There is absolutely nothing stopping two simultaneous asterisk -rx 'core stop gracefully' command executing and causing the crash (which I've verified on my machine). The patch in 1658 has some shortcomings. I forgot about the ability to cancel a shutdown, so stop gracefully could be run more than once, etc. So to stop fixing just symptoms of the problem, we'd need to come up with some way to not do two shutdowns in parallel. But, if there was a cancelled shutdown, that would still break anything that expected the atexit function to only run once. So the atexit functions would need to be run past a point where one could cancel a shutdown anyway.</pre>
<br />
<p>- Terry</p>
<br />
<p>On January 8th, 2012, 6:45 a.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Terry Wilson.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2012, 6:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this is a better candidate for fixing A18883 than r1658.
Explanation in r1658 follows.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Without this patch, the selected test (realtime_sipregs) ran for 70+ seconds and got killed by the fallback kill ('core stop now' in lib/python/asterisk/asterisk.py).
With the patch, the selected test ran for 8+ seconds and got killed cleanly (by 'core stop gracefully').</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/A18883">A18883</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/10/main/db.c <span style="color: grey">(350018)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1659/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>