<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1614/">https://reviewboard.asterisk.org/r/1614/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything looks to be in order. The non-IMAP copy function caught me off guard since it passes a null vms to the file store routine, but of course that doesn't apply to IMAP storage.</pre>
<br />
<p>- opticron</p>
<br />
<p>On December 8th, 2011, 10:15 a.m., Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2011, 10:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows the imapserver, imapport, and imapflags settings to be overridden for any voicemail user.
Note that the original patch in ASTERISK-16489 only allowed for overriding imapserver; however, that wouldn't have been terribly useful if, given two IMAP servers, any of the other server settings were different.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using integration with a gmail IMAP server / mailbox. The global settings were all set to 'dummy' values (localhost, etc.) while the actual connection settings were specified for a voicemail user. Tested leaving a voicemail, playing back the voicemail, deleting, etc. Standard IMAP integration behavior was observed using the settings obtained from the voicemail user.
Compiled with the TEST_FRAMEWORK flag (which requires fixing a warning in the UW IMAP library). Tested the vm_user unit test, which was modified to override the new IMAP settings. Test passed. Note that several other unit tests specific to app_voicemail don't pass, as they don't support IMAP.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-16489">ASTERISK-16489</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/configs/voicemail.conf.sample <span style="color: grey">(347345)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(347345)</span></li>
<li>/trunk/CHANGES <span style="color: grey">(347345)</span></li>
<li>/trunk/contrib/realtime/mysql/voicemail.sql <span style="color: grey">(347345)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1614/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>