<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1637/">https://reviewboard.asterisk.org/r/1637/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good</pre>
<br />
<p>- Matt</p>
<br />
<p>On December 22nd, 2011, 3:32 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Paul Belanger and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2011, 3:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This rather obnoxiously large patch converts every python (read: not lua) CDR test in the testsuite to use the new CDRTestCase class made by Paul and myself. It significantly reduces the amount of duplicate code within the CDR tests by offloading result checking and common pass/failure conditions to the CDRTestCase class.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All of the CDR tests have been ran to make sure they behave as expected and they have been checked to ensure that they produce the same expected CDR files (for the most part. Some elements have changed due to necessity so that soundcard dependency could be removed) and that these expectations are validated accordingly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/cdr/cdr_unanswered_yes/configs/ast1/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_unanswered_yes/configs/ast1/manager.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_unanswered_yes/run-test <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_userfield/configs/ast1/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_userfield/configs/ast1/manager.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_userfield/run-test <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast2/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast2/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/run-test <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/test-config.yaml <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/manager.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast2/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast2/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/run-test <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/test-config.yaml <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/manager.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast2/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast2/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/run-test <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/test-config.yaml <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/manager.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast2/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast2/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/run-test <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/manager.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast2/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast2/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/run-test <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/test-config.yaml <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/manager.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast2/extensions.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast2/sip.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/run-test <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/test-config.yaml <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/nocdr/configs/ast1/manager.conf <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/nocdr/run-test <span style="color: grey">(2953)</span></li>
<li>/asterisk/trunk/tests/cdr/tests.yaml <span style="color: grey">(2953)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1637/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>