<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1637/">https://reviewboard.asterisk.org/r/1637/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 22nd, 2011, 10:28 a.m., <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1637/diff/1/?file=22324#file22324line22" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/tests/cdr/cdr_userfield/run-test</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">workingdir = "cdr/cdr_userfield"</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class CDRUnansweredYesTest(CDRTestCase):</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Class name doesn't reflect test name (should be CDRUserField, if you use the same nomenclature)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just an oversight. Fixed.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 22nd, 2011, 10:28 a.m., <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1637/diff/1/?file=22334#file22334line9" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/extensions.conf</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">9</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> same => n,Set(CDR(accountcode)=cdrtest_local)</pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> same => n,Dial(SIP/2@test)</pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">exten => 2,1,Busy()</pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> same => n,Hangup()</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you need to test overriding the accountcode in this test? If not, you may want to just remove this - it makes it easier to maintain if a test only tests what it needs to (particularly when you test this in other tests as well)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unfortunately, the use of accountcode is necessary for most of these tests in order to split up the CDR records from tests that were previously using multiple servers. In addition to that, in this particular case the Master would have a local channel using "Echo" that will end at approximately the same time as the the channel we are wanting to check the CDR on, so without splitting that CDR log off somehow, that channel would create a CDR log at roughly the same time as the one that is being checked by the original tests do.</pre>
<br />
<p>- jrose</p>
<br />
<p>On December 21st, 2011, 4:14 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Paul Belanger and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2011, 4:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This rather obnoxiously large patch converts every python (read: not lua) CDR test in the testsuite to use the new CDRTestCase class made by Paul and myself. It significantly reduces the amount of duplicate code within the CDR tests by offloading result checking and common pass/failure conditions to the CDRTestCase class.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All of the CDR tests have been ran to make sure they behave as expected and they have been checked to ensure that they produce the same expected CDR files (for the most part. Some elements have changed due to necessity so that soundcard dependency could be removed) and that these expectations are validated accordingly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/test-config.yaml <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast2/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/run-test <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast2/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_userfield/configs/ast1/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_userfield/configs/ast1/manager.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_userfield/run-test <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast2/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast2/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/run-test <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_answer/test-config.yaml <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/manager.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_busy/configs/ast1/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_unanswered_yes/configs/ast1/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_unanswered_yes/configs/ast1/manager.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/cdr_unanswered_yes/run-test <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/manager.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast1/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast2/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/configs/ast2/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/run-test <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_congestion/test-config.yaml <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/manager.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast1/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast2/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/configs/ast2/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_dial_sip_transfer/run-test <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/manager.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast1/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast2/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/configs/ast2/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/run-test <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_after_busy_forward/test-config.yaml <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/manager.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast1/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast2/branch-1.4/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast2/extensions.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/configs/ast2/sip.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/run-test <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/console_fork_before_dial/test-config.yaml <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/nocdr/configs/ast1/manager.conf <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/nocdr/run-test <span style="color: grey">(2951)</span></li>
<li>/asterisk/trunk/tests/cdr/tests.yaml <span style="color: grey">(2951)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1637/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>