<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1629/">https://reviewboard.asterisk.org/r/1629/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By schmidts.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this new function enable or disable faxdetect on call base and not only about the general or peer settings. In my case using a dynamic dialplan generated from a database (not directly realtime) i want to decide on call base if i want to have faxdetect enabled or not.
For example a customer wants to use a normal fax device then faxdetect should be disabled but if someone sends a fax to his direct extension then faxreceive should be used or even the call should be redirected to his fax extension.
the usage is very simple, with SIPFAXDETECT() you will get Y or N if faxdetect is enabled or not. With SET(SIPFAXDETECT()=Yes or NO) you could enable or disable it.
just a short question, when i compile this patch against trunk everything works fine but with 1.8 i get an error about "Couldn't find function SIPFAXDETECT in XML documentation"? The patch against trunk and 1.8 is the same and it works fine on both.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">testing done with several sent faxes into some extensions with faxdetect enable or not.
when its enabled the call jumps to the fax extension and doesnt if its not enabled.
same => n,SET(SIPFAXDETECT()=NO)
same => n,Noop(FAXDETECTION: ${SIPFAXDETECT()})
Executing [1@in_world:6] Set("SIP/proxy-00000026", "SIPFAXDETECT()=NO") in new stack
Executing [1@in_world:7] NoOp("SIP/proxy-00000026", "FAXDETECTION: N") in new stack
Executing [1@in_world:8] Set("SIP/proxy-00000026", "SIPFAXDETECT()=YES") in new stack
Executing [1@in_world:9] NoOp("SIP/proxy-00000026", "FAXDETECTION: Y") in new stack
..
Redirecting 'SIP/proxy-00000026' to fax extension due to CNG detection
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/channels/chan_sip.c <span style="color: grey">(348360)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1629/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>