<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1628/">https://reviewboard.asterisk.org/r/1628/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unlock(Ship it!)</pre>
<br />
<p>- Matt</p>
<br />
<p>On December 16th, 2011, 11:28 a.m., rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2011, 11:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch simply adds lock protection around CDR API calls that access an ast_channel pointer.
The ast_cdr_setcid() and ast_cdr_update() were shown in ASTERISK-18836 to be called by different threads for the same channel. The channel driver thread and the PBX thread running dialplan.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles and I can see the potential for reentrancy from other threads.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18836">ASTERISK-18836</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_authenticate.c <span style="color: grey">(348310)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_followme.c <span style="color: grey">(348310)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_queue.c <span style="color: grey">(348310)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/1.8/funcs/func_cdr.c <span style="color: grey">(348310)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/1.8/include/asterisk/cdr.h <span style="color: grey">(348310)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/1.8/main/channel.c <span style="color: grey">(348310)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/1.8/main/features.c <span style="color: grey">(348310)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/1.8/main/pbx.c <span style="color: grey">(348310)</span></li>
<li>http://svn.asterisk.org/svn/asterisk/branches/1.8/res/res_monitor.c <span style="color: grey">(348310)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1628/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>