<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1619/">https://reviewboard.asterisk.org/r/1619/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2011, 2:31 a.m., <b>Olle E Johansson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this is a good addition. I created something similar with custom devstates in the dial plan earlier, but it was a bit messy. You might want to complete the devstate addition with ast_devstate_prov_add() and ast_devstate_prov_del() with the callbacks.</pre>
</blockquote>
<p>On December 13th, 2011, 2:51 a.m., <b>schmidts</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i also think this is a good adition but i think it would be better to stay at the hint scheme and use something like exten => 123,hint,QUEUE/night_queue instead of Queue:. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry i was wrong about this, i havent thought about the devicestate providers which are allready using the Name: scheme ;)</pre>
<br />
<p>- schmidts</p>
<br />
<p>On December 12th, 2011, 9:45 p.m., Alec Davis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Alec Davis.</div>
<p style="color: grey;"><i>Updated Dec. 12, 2011, 9:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note: the 2 debug print lines will go.
Picking up queues is possible, but knowing that a queue is ringing is useful,
particulary when you are not logged in to that queue, or not a member of it.
Non BLF users, dial 72# and then are connected with caller.
If they forget to press # or the SEND button they think the pickup hasn't worked.
Not understanding there is a 3-4 second delay before the SIP call is placed.
exten => 72,hint,Queue:night_queue ;queue NIGHT BELL
exten => _72,1,NoOp(Pickup Night Bell)
exten => _72,n,Pickup(4999@isdn) ;direct call pickup to local Asterisk
exten => _72,n,NoOp(PICKUPRESULT=${PICKUPRESULT})
exten => _72,n,Hangup()
exten => **72,1,Goto(72,1)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In use for months on a 1.8.5 production box.
NightBell usage:
Users with BLFs configured hear the nightbells, and see the BLF flash, press the BLF and are immediately connected with caller.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/apps/app_queue.c <span style="color: grey">(348014)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1619/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>