<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1187/">https://reviewboard.asterisk.org/r/1187/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Truth be told, progress isn't really a state... it's just an indication. Usually I think it's just used for Early Media, but I don't really know all the implications behind it, so it might be proper to call it an indication event. But you seem to have already talked with Russell about this a while back going on the conversation in here and came to the conclusion that this wouldn't work for some reason.
The only thing I'm at all worried about at this point is that we come back later and decide that this really should have been a different kind of event and have to make an option to keep this behavior instead of just discarding it outright. Even then it wouldn't be that horribly big of a deal, and I generally agree with having an ami event for tracking this, so you can go ahead and commit this.</pre>
<br />
<p>- jrose</p>
<br />
<p>On September 19th, 2011, 6:43 a.m., Olle E Johansson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Russell Bryant.</div>
<div>By Olle E Johansson.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2011, 6:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a manager event for early media. Using the existing Newstate event with a "faked" state called "progress".
In the long run, this is not the right thing to do, but after discussion with Russell on asterisk-dev it was concluded that it was the easiest way forward.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested many calls in the 1.4 version of the same patch.
One-legged calls using the progress() dialplan app, two legged calls using dial().</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/19135">19135</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/oej/bring-in-the-early-media-trunk/apps/app_dial.c <span style="color: grey">(332755)</span></li>
<li>/team/oej/bring-in-the-early-media-trunk/main/pbx.c <span style="color: grey">(332755)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1187/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>