<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1607/">https://reviewboard.asterisk.org/r/1607/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By may213.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2011, 1:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CODING-GUIDELINE issues fixed for changed codes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is direct rtp support for chan_ooh323 channel driver.
It work like chan_sip direct rtp support based on directmedia (directrtp) option that can be global or per peer/user.
Also there is earlydirect (directrtpsetup) option that allow setup direct rtp connection for early media.
On h.323 side there can be two modes to enable direct rtp - with or without renegotiation media channels.
If there are opened media channels (logical channels in h.323) then renegotiation must be done and it caused by
sending empty terminalcapabilities set to opposite side. If empty tcs is arrived transmit logical channels
will be closed then reopen with new rtp addresses.
if there are no opened channels then new rtp addresses come in the new fast start proposal or just saved
for further use in the channel open negotiation (it is for fast start disabled case).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">h.323->h.323 (fast start enabled & disabled), h.323->sip, sip->h.323 remote bridging are tested and work well.
Another rtp based channels (sccp, jingle) are not tested but must work.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/Makefile <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/chan_ooh323.h <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooCalls.h <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooCmdChannel.c <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooLogChan.h <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooLogChan.c <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooStackCmds.h <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooStackCmds.c <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooh245.h <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooh245.c <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooh323.c <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooh323ep.c <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooq931.h <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323c/src/ooq931.c <span style="color: grey">(347865)</span></li>
<li>/trunk/addons/ooh323cDriver.c <span style="color: grey">(347865)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1607/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>