<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1615/">https://reviewboard.asterisk.org/r/1615/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. Thanks for getting this patched so fast.</pre>
<br />
<p>- Matt</p>
<br />
<p>On December 8th, 2011, 3:10 p.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2011, 3:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-384</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After applying, I get this:
$ sudo ./runtests.py -t tests/channels/SIP/sip_tls_register
Running tests for Asterisk SVN-branch-1.8-r347595M ...
--> Running test 'tests/channels/SIP/sip_tls_register' ...
Making sure Asterisk isn't running ...
Running ['tests/channels/SIP/sip_tls_register/run-test'] ...
Parsing /tmp/asterisk-testsuite/channels/SIP/sip_tls_register/ast8/etc/asterisk/extconfig.conf
Parsing /tmp/asterisk-testsuite/channels/SIP/sip_tls_register/ast8/etc/asterisk/logger.conf
Parsing /tmp/asterisk-testsuite/channels/SIP/sip_tls_register/ast8/etc/asterisk/logger.general.conf.inc
Parsing /tmp/asterisk-testsuite/channels/SIP/sip_tls_register/ast8/etc/asterisk/logger.logfiles.conf.inc
[Dec 08 22:07:23] WARNING[13342]: asterisk.TestCase:217 __reactor_timeout: Reactor timeout: '30' seconds
<?xml version="1.0" encoding="utf-8"?>
<testsuite errors="0" failures="0" name="AsteriskTestSuite" tests="1" time="37.80">
<testcase name="tests/channels/SIP/sip_tls_register" time="37.80"/>
</testsuite>
I don't like the reactor timeout, but the test claims to have succceded.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(347652)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1615/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>