<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1572/">https://reviewboard.asterisk.org/r/1572/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>


<p style="color: grey;"><i>Updated Dec. 6, 2011, 1:06 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a regression test for my fix in r1570. It&#39;s not real pretty, but it does the job: show that the config load order is slightly broken.

Regard it as a stub that could be expanded whenever someone wants to fiddle with the app_voicemail configuration options.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The test case does this, until r1570 is committed: first run fails, second run succeeds.

*CLI&gt; test execute category /apps/app_voicemail/ name test_voicemail_load_config
Running all available tests matching category /apps/app_voicemail/ and name test_voicemail_load_config

START  /apps/app_voicemail/ - test_voicemail_load_config 
[app_voicemail.c:test_voicemail_load_config:13002]: mailbox 00000002 should have locale &#39;de_DE.UTF-8&#39;, but has &#39;&#39;
Failed to load configuration file.
END    /apps/app_voicemail/ - test_voicemail_load_config Time: &lt;1ms Result: FAIL

1 Test(s) Executed  0 Passed  1 Failed
*CLI&gt; test execute category /apps/app_voicemail/ name test_voicemail_load_config
Running all available tests matching category /apps/app_voicemail/ and name test_voicemail_load_config

START  /apps/app_voicemail/ - test_voicemail_load_config 
Failed to load configuration file.
END    /apps/app_voicemail/ - test_voicemail_load_config Time: &lt;1ms Result: PASS

1 Test(s) Executed  1 Passed  0 Failed*CLI&gt; test execute category /apps/app_voicemail/ name test_voicemail_load_config
Running all available tests matching category /apps/app_voicemail/ and name test_voicemail_load_config

START  /apps/app_voicemail/ - test_voicemail_load_config 
[app_voicemail.c:test_voicemail_load_config:13002]: mailbox 00000002 should have locale &#39;de_DE.UTF-8&#39;, but has &#39;&#39;
Failed to load configuration file.
END    /apps/app_voicemail/ - test_voicemail_load_config Time: &lt;1ms Result: FAIL

1 Test(s) Executed  0 Passed  1 Failed
*CLI&gt; test execute category /apps/app_voicemail/ name test_voicemail_load_config
Running all available tests matching category /apps/app_voicemail/ and name test_voicemail_load_config

START  /apps/app_voicemail/ - test_voicemail_load_config 
Failed to load configuration file.
END    /apps/app_voicemail/ - test_voicemail_load_config Time: &lt;1ms Result: PASS

1 Test(s) Executed  1 Passed  0 Failed



When r1570 is also applied, the first run of test succeeds too, like expected.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/1.8/apps/app_voicemail.c <span style="color: grey">(347109)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1572/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>