<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1606/">https://reviewboard.asterisk.org/r/1606/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers and Terry Wilson.</div>
<div>By wdoekes.</div>


<p style="color: grey;"><i>Updated Dec. 2, 2011, 10:56 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed Pauls comments.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created a test suite for the REGISTER problems of r1533:


SCENARIO_TABLE = (
    (&#39;USER&#39;,    &#39;SECRET&#39;,       &#39;USERADDR&#39;,                 &#39;RESP&#39;),

    (&#39;baduser&#39;, &#39;badsecret&#39;,    &#39;baduser@mydom.com&#39;,        403), # authreject
    (&#39;baduser&#39;, &#39;badsecret&#39;,    &#39;baduser@127.0.0.1&#39;,        403), # bad both

    (&#39;someuser&#39;, &#39;somesecret&#39;,  &#39;someuser@mydom.com&#39;,       200), # ok
    (&#39;someuser&#39;, &#39;badsecret&#39;,   &#39;someuser@mydom.com&#39;,       403), # bad pass
    (&#39;someuser&#39;, &#39;somesecret&#39;,  &#39;someuser@mydom2.com&#39;,      200), # ok
    (&#39;someuser&#39;, &#39;somesecret&#39;,  &#39;someuser@mydom3.com&#39;,      403), # bad domain
    (&#39;someuser&#39;, &#39;somesecret&#39;,  &#39;someuser@&#39;,                404), # bad sip
    (&#39;someuser&#39;, &#39;somesecret&#39;,  &#39;@someuser&#39;,                403), # bad dom/sip

    (&#39;mydom.com&#39;, &#39;mysecret&#39;,   &#39;mydom.com@mydom.com&#39;,      200), # ok
    (&#39;mydom.com&#39;, &#39;mysecret&#39;,   &#39;mydom.com@mydom2.com&#39;,     200), # ok
    (&#39;mydom.com&#39;, &#39;mysecret&#39;,   &#39;mydom.com&#39;,                200), # ok(!)
    (&#39;mydom.com&#39;, &#39;mysecret&#39;,   &#39;mydom.com@&#39;,               404), # not ok
    #(&#39;mydom.com&#39;, &#39;mysecret&#39;,   &#39;@mydom.com&#39;,               200), # ok(BAH!)
)
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before applying r1533:
  6 errors
After:
  0 errors

Changes between pre-r1533:
- 404 (&#39;baduser&#39;, &#39;badsecret&#39;,    &#39;baduser@127.0.0.1&#39;,        403)
- 404 (&#39;someuser&#39;, &#39;somesecret&#39;,  &#39;someuser@mydom3.com&#39;,      403)
- 401/200 (&#39;someuser&#39;, &#39;somesecret&#39;,  &#39;someuser@&#39;,            404)
- 404 (&#39;someuser&#39;, &#39;somesecret&#39;,  &#39;@someuser&#39;,                403)
- 403 (&#39;mydom.com&#39;, &#39;mysecret&#39;,   &#39;mydom.com&#39;,                200)
- 401/200 (&#39;mydom.com&#39;, &#39;mysecret&#39;,   &#39;mydom.com@&#39;,           404)</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/lib/python/asterisk/sipp.py <span style="color: grey">(2817)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg200.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg403.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg404.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: grey">(2817)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1606/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>