<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1608/">https://reviewboard.asterisk.org/r/1608/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, otherwiseguy and may213.</div>
<div>By mjordan.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows app_dial to report whether or not a channel timed out using the DIALSTATUS variable. Previously, if a channel timed out (hangup cause code AST_CAUSE_NO_USER_RESPONSE), it would be treated as a "NOANSWER". This patch adds a new value that can be returned in the DIALSTATUS variable "TIMEDOUT", and reports the value in CDR logs. Note that the CEL already use the actual text of the hang up cause code, so modification to them is not necessary.
Note that adding a new DIALSTATUS hangup value appeared to require some modifications to the H.323 channel drivers - hence the updates for them included in this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing was done using two Polycom SIP phones. After registration, one of the phones would be disconnected to force a timeout when Asterisk would dial it. When the connected phone would dial the disconnected phone, the INVITE would time out and a DIALSTATUS of TIMEDOUT was returned in the dialplan. Testing was also done to ensure that BUSY and CONGESTION were returned in normal scenarios.
Testsuite tests will be written for this patch, both to test the DIALSTATUS variable as well as the CDR logs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/CHANGES <span style="color: grey">(346761)</span></li>
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(346761)</span></li>
<li>/trunk/apps/app_dial.c <span style="color: grey">(346761)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(346761)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(346761)</span></li>
<li>/trunk/include/asterisk/cdr.h <span style="color: grey">(346761)</span></li>
<li>/trunk/main/cdr.c <span style="color: grey">(346761)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1608/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>