<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1518/">https://reviewboard.asterisk.org/r/1518/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great work!</pre>
<br />
<p>- David</p>
<br />
<p>On November 17th, 2011, 9:43 a.m., mjordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and David Vossel.</div>
<div>By mjordan.</div>
<p style="color: grey;"><i>Updated Nov. 17, 2011, 9:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds two new menu features to ConfBridge, admin_toggle_menu_participants and participant_count. The admin action will globally mute / unmute all participants on a conference, while the participant count simply exposes the existing participant count function to the conference bridge menu.
Note that this is a port of the patch supplied by Kevin Reeves on ASTERISK-18204. Very minor modifications were made to that patch, including adding sound file overriding to the config parser and some general overall cleanup.
This also makes a minor change that outputs the caller ID of the participants when the CLI command to list a specific conf bridge is used. As this is useful and a minor modification, it was left in with this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using a polycom phone and zoiper softphone. No sound file quality issues were detecting in playing back the global sound using the conference bridge channel, which was an issue Kevin originally reported with his first implementation. There did not appear to be any locking issues with the implementation proposed by Kevin.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18204">ASTERISK-18204</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/confbridge/conf_config_parser.c <span style="color: grey">(345544)</span></li>
<li>/trunk/apps/confbridge/include/confbridge.h <span style="color: grey">(345544)</span></li>
<li>/trunk/configs/confbridge.conf.sample <span style="color: grey">(345544)</span></li>
<li>/trunk/apps/app_confbridge.c <span style="color: grey">(345544)</span></li>
<li>/trunk/CHANGES <span style="color: grey">(345544)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1518/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>