<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1565/">https://reviewboard.asterisk.org/r/1565/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree that the defaults in any config file should match the defaults in the code, unless explicitly documented otherwise.</pre>
<br />
<p>- Tilghman</p>
<br />
<p>On November 4th, 2011, 4:53 a.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2011, 4:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since Pauls r1455 is stalled -- thread safety issues -- I'd like to address this old bug.
In udptl.conf.sample the UDPTL port range is 4000-4999.
In udptl.c it is 4500-4599 if you don't have a config file.
If you do have a config file, it's 4500-4999.
I'd like to change them all to 4000-4999. The reason: I suspect that most people using this will have the config file from the samples and thus will already have 4000-4999.
The drawback would be that those that have a smaller range port mapped / firewall-allowed would now get failed UDPTL connections. But, this is what the UPGRADE.txt is for.
I suggest adding it to branch 10 because it is a difference in behaviour, but not large enough that it will spoil the release.
(The changeset also fixes a typo, and the oddity that supplying 4002-4002 would become 4500-4999, while 4002-4003 would become 4002-4002 if you had use_even_ports=yes.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-16250">ASTERISK-16250</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/10/UPGRADE.txt <span style="color: grey">(343442)</span></li>
<li>/branches/10/main/udptl.c <span style="color: grey">(343442)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1565/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>