<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1551/">https://reviewboard.asterisk.org/r/1551/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've marked this as 'discarded'; the solution that has been committed is preferable, this is not necessary.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On October 28th, 2011, 4:01 a.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2011, 4:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch takes a different approach to the mentioned bug.
I added an autoconf script to detect whether integer misalignment causes failures or not. This autoconf define HAVE_NO_MISALIGNMENT can then be used instead of __sparc__ and __arm__ and __some_other_arch__.
Note that this is *not* mutually exclusive with https://reviewboard.asterisk.org/r/1549. If that code is committed, this could still be added but without the changes in main/utils.c. This just won't be as important anymore.
Regards,
Walter
(I also replaced the modulo sizeof(ast_string_field_allocation) with modulo 2. The rest of the code assumed it was 2, and now that's more obvious.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">S Adrian from the bug report tested whether the autoconf script put HAVE_NO_MISALIGNMENT in autoconfig.h. It does on his ARM.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-17310">ASTERISK-17310</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/autoconf/ast_c_no_misalign.m4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/1.8/configure.ac <span style="color: grey">(342659)</span></li>
<li>/branches/1.8/include/asterisk/autoconfig.h.in <span style="color: grey">(342659)</span></li>
<li>/branches/1.8/include/asterisk/unaligned.h <span style="color: grey">(342659)</span></li>
<li>/branches/1.8/main/utils.c <span style="color: grey">(342659)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1551/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>