<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1523/">https://reviewboard.asterisk.org/r/1523/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good cleanup!</pre>
 <br />







<p>- Olle E</p>


<br />
<p>On October 13th, 2011, 3:33 a.m., wdoekes wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers and Terry Wilson.</div>
<div>By wdoekes.</div>


<p style="color: grey;"><i>Updated Oct. 13, 2011, 3:33 a.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since 1.6(.2?), &quot;sipusers&quot; has been gone from chan_sip. I suspect sippeers now does what sipfriends was supposed to do again, but changing the preferred the name back to sipfriends again sounds like a bad plan.

This patch removes all leftover references to sipusers and renames sipfriends to sippeers where possible.

(Reviewboard didn&#39;t let me upload the patch with &#39;svn mv ...sipfriends.sql ...sippeer.sql&#39; , but the file should be renamed as well.)</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">None whatsoever, but the only code changes involve removing 1 line and editing documentation strings.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/1.8/contrib/realtime/mysql/sipfriends.sql <span style="color: grey">(340769)</span></li>

 <li>branches/1.8/main/config.c <span style="color: grey">(340769)</span></li>

 <li>branches/1.8/res/res_realtime.c <span style="color: grey">(340769)</span></li>

 <li>branches/1.8/contrib/realtime/mysql/sipfriends.sql <span style="color: grey">(340769)</span></li>

 <li>branches/1.8/configs/dbsep.conf.sample <span style="color: grey">(340769)</span></li>

 <li>branches/1.8/configs/extconfig.conf.sample <span style="color: grey">(340769)</span></li>

 <li>branches/1.8/configs/res_config_mysql.conf.sample <span style="color: grey">(340769)</span></li>

 <li>branches/1.8/configs/res_ldap.conf.sample <span style="color: grey">(340769)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1523/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>