<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1505/">https://reviewboard.asterisk.org/r/1505/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Olle E Johansson and wdoekes.</div>
<div>By schmidts.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2011, 9:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i reopen this review cause i have found a racecondition when a sip client doesnt sent a contact header in a 1xx response, the UPDATE message will also be sent to a wrong destination and mostly the transfered call will fail.
By adding a small check for a okcontacturi this problem could be avoided. Connected line update doesnt work in this case.
thanks wdoekes2 for this simple solution ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i have found a problem with a blond transfer and connected_line UPDATE messages.
When doing a transfer to a ringing channel the UPDATE message will not have any route information attached cause the route header is only parsed on a 200 response and not on a 180.
this small patch parses the contact header and also sets the proper route information even on a 180 respsonse so when an UPDATE messages is sent out, the route header is attached.
maybe doing the same for a 183 response would also be a good idea.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">asterisk is behind a kamailio sip proxy which drops in-dialog messages with no prober route header. after parsing the route header of a 180 reponse the proxy forwards the information to the right end point.
normal transfer, blind transfer, ringing ... works fine.
CONNECTED_LINE function after the transfer also works like expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/schmidts/unleash-the-beast/addons/Makefile <span style="color: grey">(340808)</span></li>
<li>team/schmidts/unleash-the-beast/apps/app_dial.c <span style="color: grey">(340808)</span></li>
<li>team/schmidts/unleash-the-beast/channels/chan_sip.c <span style="color: grey">(340808)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1505/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>