<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1362/">https://reviewboard.asterisk.org/r/1362/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alright, looks like you handled it quite proficiently.

I&#39;m hearing right now you don&#39;t have commit access to svn yet, and Leif is wanting to release a new 10 beta today, so I&#39;ll just go ahead and do all the closing tasks from here.  Thanks very much for your efforts!</pre>
 <br />







<p>- jrose</p>


<br />
<p>On September 21st, 2011, 1:56 p.m., elguero wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By elguero.</div>


<p style="color: grey;"><i>Updated Sept. 21, 2011, 1:56 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Security Events Framework was added in 1.8 and support was added for AMI to generate events at that time.

This patch attempts to add support in chan_sip to generate security events.  Hopefully we can get this into Asterisk 10.

I am looking forward to hearing feedback on where this patch can be improved especially from those who have an intimate knowledge of chan_sip.

Thanks</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local dev machine and a softphone.  Generated events by using the wrong username, wrong password, wrong auth name, successful authentication.</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-18264">ASTERISK-18264</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/10/CHANGES <span style="color: grey">(337324)</span></li>

 <li>/branches/10/channels/chan_sip.c <span style="color: grey">(337324)</span></li>

 <li>/branches/10/channels/sip/include/security_events.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/branches/10/channels/sip/include/sip.h <span style="color: grey">(337324)</span></li>

 <li>/branches/10/channels/sip/security_events.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/branches/10/configs/logger.conf.sample <span style="color: grey">(337324)</span></li>

 <li>/branches/10/include/asterisk/event_defs.h <span style="color: grey">(337324)</span></li>

 <li>/branches/10/include/asterisk/security_events_defs.h <span style="color: grey">(337324)</span></li>

 <li>/branches/10/main/event.c <span style="color: grey">(337324)</span></li>

 <li>/branches/10/main/security_events.c <span style="color: grey">(337324)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1362/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>