<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1421/">https://reviewboard.asterisk.org/r/1421/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't really like the idea of adding a debug command to the manager.conf file at all. That seems like the wrong way to go about this. I'd much prefer to see you use the logger.conf file to control the logging. This allows the administrator to determine where and what is being logged, and when. You could add a logger channel called 'manager' if that isn't already there. That way an administrator could like to a file, or enable it via the console if they wished. In addition to that, I'd like to see it controlled via a CLI command like 'manager set debug {on|off|<level>}' to give an administrator the ability to control when they see the manager debug on the console.</pre>
<br />
<p>- Leif</p>
<br />
<p>On September 7th, 2011, 9:14 a.m., Olle E Johansson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Olle E Johansson.</div>
<p style="color: grey;"><i>Updated Sept. 7, 2011, 9:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a new option to manager.conf. When enabled, all manager actions will be output in the CLI session, in order to be able to debug a system controlled by AMI connections.
Red dots will be removed before commit</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine on my system and a system at customer site in 1.4 version. The 1.8 version is not much different.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18447">ASTERISK-18447</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/oej/rana-manager-debug-trunk/configs/manager.conf.sample <span style="color: grey">(334684)</span></li>
<li>/team/oej/rana-manager-debug-trunk/main/manager.c <span style="color: grey">(334684)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1421/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>