<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1405/">https://reviewboard.asterisk.org/r/1405/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. This could conceivably cause an issue if someone defined manager.general.conf.inc, set the bindaddr to something other than 127.0.0.x, and expected it to work - but I don't see that as a major concern.</pre>
<br />
<p>- mjordan</p>
<br />
<p>On September 1st, 2011, 2:07 p.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2011, 2:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch does two things:
1 - Enable the manager by default. We rely on it for a lot testing, we might as well enable my default.
2 - Remove the need for adding manager.general.conf.inc.
For the manager, we now create the configuration file for more then 1 instance of asterisk automatically. This is needed because of the bindaddr setting, we need to bind to another virtual loopback adapter. This was a pain for a test writer to remember, and a pain for somebody maintaining the testsuite.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local development box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/configs/manager.conf <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/apps/directory_operator_exit/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/apps/directory_operator_exit/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/callparking/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/callparking/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/cdr/console_dial_sip_answer/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/directed_pickup/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fastagi/channel-status/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fastagi/connect/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fastagi/control-stream-file/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fastagi/database/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fastagi/stream-file/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_g711_t38/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_g711_t38/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix1/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix1/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix2/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix2/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix3/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix3/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix4/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix4/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_native_t38/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_native_t38/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_native_t38_ced/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_native_t38_ced/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_no_t38/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_no_t38/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_t38_g711/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_t38_g711/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout1/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout1/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout2/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout2/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout3/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout3/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout4/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout4/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout5/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout5/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/func_srv/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/manager/login/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/pbx/merge_contexts/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/pbx/merge_contexts/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/pbx/pbx_lua_background/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/pbx/pbx_lua_background/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/pbx/pbx_lua_goto/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/pbx/pbx_lua_goto/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/regressions/M18882/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/udptl/configs/ast1/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
<li>asterisk/trunk/tests/udptl/configs/ast2/manager.general.conf.inc <span style="color: grey">(2057)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1405/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>