<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1392/">https://reviewboard.asterisk.org/r/1392/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2011, 8:38 p.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wow, something wrong with this diff. Not sure what happened, but lots of unneeded changes included.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops, sorry. Still learning to use post-review, and I think it picked the wrong branch of my git-svn tree to use as a base. Should be fixed now.</pre>
<br />
<p>- dwmw2</p>
<br />
<p>On August 26th, 2011, 6:36 p.m., dwmw2 wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By dwmw2.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2011, 6:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix two problems with app_sms.
Firstly, the 'flags' field on the stack in sms_exec() is uninitialised, causing it to use the wrong protocol in some cases.
Secondly, when disconnect supervision is not working or inbanddisconnect=yes is set in chan_dahdi.conf, app_sms was failing to terminate the call after it sent the REL(ease) message and the peer stopped talking to it. This patch fixes the code to handle the 'bad stop bit' message more gracefully in that case, and hang up the call.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sending and receiving protocol 1 messages to/from British Telecom over ISDN BRI (with chan_dahdi), both with and without inbanddisconnect=yes.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18331">ASTERISK-18331</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/Makefile <span style="color: grey">(333075)</span></li>
<li>/trunk/apps/app_sms.c <span style="color: grey">(333428)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(333075)</span></li>
<li>/trunk/build_tools/mkpkgconfig <span style="color: grey">(333075)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(333075)</span></li>
<li>/trunk/configure <span style="color: grey">(333075)</span></li>
<li>/trunk/configure.ac <span style="color: grey">(333075)</span></li>
<li>/trunk/makeopts.in <span style="color: grey">(333075)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(333075)</span></li>
<li>/trunk/res/res_jabber.c <span style="color: grey">(333075)</span></li>
<li>/trunk/sounds/Makefile <span style="color: grey">(333075)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1392/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>