<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1386/">https://reviewboard.asterisk.org/r/1386/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2011, 12:25 p.m., <b>mjordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. I'll merge this into the logging stuff once this is in trunk and post it up for review. The comments below will help if the test has something seriously wrong with it, but aren't strictly necessary.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup, like I said. If you and jrose move your tests into a group branch, I can help update them.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2011, 12:25 p.m., <b>mjordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1386/diff/1/?file=19249#file19249line74" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/trunk/tests/channels/SIP/sip_tls_call/run-test</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> ami.originate(channel = "SIP/testast1/1000", context = "default", exten = "1000", priority = "1")</pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">72</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> ami.originate(channel = "SIP/testast1/1000", context = "default", exten = "1000", priority = "1")</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you feel like it, since you put the check previously to prevent other AMI instances from spawning an originate, you may want to also put an error callback on the deferred object in case the originate fails.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree, however I'll leave them out of this patch. I'll address it shortly.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2011, 12:25 p.m., <b>mjordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1386/diff/1/?file=19250#file19250line155" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/trunk/tests/chanspy/chanspy_barge/run-test</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">155</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> if self.ast_version < AsteriskVersion("1.6.2"):</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">134</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> self.ast1.cli_originate("SIP/end_b extension chanspytest@test")</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Error callback here too</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2011, 12:25 p.m., <b>mjordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1386/diff/1/?file=19250#file19250line161" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/trunk/tests/chanspy/chanspy_barge/run-test</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">161</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> if self.ast_version < AsteriskVersion("1.6.2"):</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">137</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> self.ast1.cli_originate("Local/play_recording@test extension detect_audio@test")</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Error callback here too</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same</pre>
<br />
<p>- Paul</p>
<br />
<p>On August 26th, 2011, 12:38 p.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2011, 12:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes the OptionParser logic from all tests, and fixes the following:
A) It is deprecated in python 2.7
2) Is a sloppy way to pass data into a test
3) Not even needed.
I've also added cli_aliases.conf file to fix the logic around ast_version.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local development box</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/chanspy/chanspy_barge/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer_v6/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_register/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_srtp/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_tls_call/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_attended_transfer_tcp/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/sip_attended_transfer/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/options/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/secure_bridge_media/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/noload_res_srtp_attempt_srtp/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/message_unauth/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/noload_res_srtp/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/message_disabled/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/message_from_call/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/callparking/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/channels/SIP/message_auth/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/asttest/asttest.c <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/configs/cli_aliases.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/runtests.py <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/apps/directory_attendant_exit/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/apps/directory_context_operator_exit/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/apps/directory_operator_exit/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/directed_pickup/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/dynamic-modules/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/channel-status/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/connect/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/control-stream-file/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/database/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/execute/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/get-data/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/hangup/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/record-file/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/say-alpha/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/say-date/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/say-datetime/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/say-digits/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/say-number/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/say-phonetic/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/say-time/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/stream-file/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fastagi/wait-for-digit/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_g711_t38/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix1/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix2/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix3/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_mix4/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_native_t38/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_native_t38_ced/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_no_t38/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_t38_g711/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout1/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout2/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout3/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout4/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/fax/gateway_timeout5/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/feature_attended_transfer/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/feature_blonde_transfer/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/func_srv/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/iax2/basic-call/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/manager/event-monitor/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/manager/login/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/mixmonitor/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/one-step-parking/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/pbx/call-files/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/pbx/merge_contexts/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/pbx/pbx_lua_background/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/pbx/pbx_lua_goto/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/regressions/M18882/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/udptl/run-test <span style="color: grey">(1959)</span></li>
<li>asterisk/trunk/tests/udptl_v6/run-test <span style="color: grey">(1959)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1386/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>