<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1382/">https://reviewboard.asterisk.org/r/1382/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Paul Belanger.</div>
<div>By mjordan.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2011, 4:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated to produce single log file(s) for all test runs. A messages.log and full.log are created, set at INFO / DEBUG respectively. A RollingFileHandler is used, with a 6MB limit set to roll at 5 / 10 files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pulled out the logging functionality from review 1380 (https://reviewboard.asterisk.org/r/1380/). That review will be updated once this review is completed.
This review adds Python logging to the test suite. The Python libraries were updated to use this. Note that runtests.py now creates a log file log-console-output.txt to not conflict with the Python log created by TestCase.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Python logging was used in all of the new VoiceMailMain tests, on review at https://reviewboard.asterisk.org/r/1380/. Tested with a variety of log levels, including DEBUG, INFO, WARN, and ERROR.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/asttest/asttest.c <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ami.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/cdr.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/config.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/sipp.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/version.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/voicemail.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/lib/python/client.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/logger.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/runtests.py <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/extensions.conf <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/run-test <span style="color: grey">(1983)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/tests.yaml <span style="color: grey">(1983)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1382/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>