<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1382/">https://reviewboard.asterisk.org/r/1382/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1382/diff/1/?file=19161#file19161line18" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/runtests.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kn">import</span> <span class="nn">tempfile</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is no longer needed and should be removed.</pre>
</div>
<br />
<p>- mjordan</p>
<br />
<p>On August 25th, 2011, 1:39 p.m., mjordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Paul Belanger.</div>
<div>By mjordan.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2011, 1:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pulled out the logging functionality from review 1380 (https://reviewboard.asterisk.org/r/1380/). That review will be updated once this review is completed.
This review adds Python logging to the test suite. The Python libraries were updated to use this. Note that runtests.py now creates a log file log-console-output.txt to not conflict with the Python log created by TestCase.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Python logging was used in all of the new VoiceMailMain tests, on review at https://reviewboard.asterisk.org/r/1380/. Tested with a variety of log levels, including DEBUG, INFO, WARN, and ERROR.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/fastagi/say-datetime/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/say-digits/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/say-number/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/say-phonetic/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/say-time/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/wait-for-digit/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/feature_attended_transfer/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/feature_blonde_transfer/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/iax2/basic-call/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/manager/event-monitor/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/mixmonitor/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/one-step-parking/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/pbx/call-files/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/udptl_v6/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/say-alpha/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/say-date/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/record-file/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/hangup/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/execute/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/fastagi/get-data/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/directed_pickup/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/chanspy/chanspy_barge/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer_v6/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_register/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_attended_transfer_tcp/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_attended_transfer/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/version.py <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/voicemail.py <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/runtests.py <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/extensions.conf <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/tests.yaml <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/sipp.py <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/config.py <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/cdr.py <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ami.py <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/asttest/asttest.c <span style="color: grey">(1911)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(1911)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1382/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>