<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
It is very good and important that this functionality gets into
proper released Asterisk.<br>
<br>
The same logic is included in implementations in some other
implementation environments. So it makes very good sense to have it
in Asterisk as well. <br>
<br>
Thanks,<br>
Gunnar <br>
<br>
-----------------<br>
<br>
Terry Wilson skrev 2011-08-24 20:25:
<blockquote cite="mid:20110824182539.9339.12960@hotblack.digium.com"
type="cite">
<div style="font-family: Verdana,Arial,Helvetica,Sans-Serif;">
<table style="border: 1px solid rgb(201, 195, 153);"
width="100%" bgcolor="#f9f3c9" cellpadding="8">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To reply,
visit: <a moz-do-not-send="true"
href="https://reviewboard.asterisk.org/r/1356/">https://reviewboard.asterisk.org/r/1356/</a>
</td>
</tr>
</tbody>
</table>
<br>
<pre style="white-space: pre-wrap; word-wrap: break-word;">If no one has a problem with this change, I'm going to go ahead and commit it tomorrow even without a "Ship It!" since it isn't originally my patch and therefor I just as easily could have reviewed it myself. I just wanted to make sure to give people a chance to comment.</pre>
<br>
<p>- Terry</p>
<br>
<p>On August 9th, 2011, 11:27 a.m., Terry Wilson wrote:</p>
<table style="background-image:
url("https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png");
background-position: left top; background-repeat: repeat-x;
border: 1px solid black;" width="100%" bgcolor="#fefadf"
cellpadding="8" cellspacing="0">
<tbody>
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2011, 11:27
a.m.</i></p>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt;
margin-top: 1.5em;">Description </h1>
<table style="border: 1px solid rgb(184, 181, 160);"
width="100%" bgcolor="#ffffff" cellpadding="10"
cellspacing="0">
<tbody>
<tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">This patch was submitted by Emmanuel BUU on JIRA. I have just updated it for trunk and done some testing.
This patch causes the send_text() function (and therefor the SendText dialplan application and other places in the code) to use the write_text() callback to write text frames to the channel instead of using the send_text callback to do a more out-of-band transmission. If text has not been negotiated, or there is no write_text callback, things behave as they always have.
I am placing this up for review so that there can be some public discussion just to make sure this seems like reasonable behavior to everyone.</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt;
margin-top: 1.5em;">Testing </h1>
<table style="border: 1px solid rgb(184, 181, 160);"
width="100%" bgcolor="#ffffff" cellpadding="10"
cellspacing="0">
<tbody>
<tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">I have tested with SIPcon1 and verified that the T.140 text works. I have also tried with a client that didn't support real-time text and saw that SIP MESSAGE requests were sent as they were before.</pre>
</td>
</tr>
</tbody>
</table>
<div style="margin-top: 1.5em;"> <b style="color:
rgb(87, 80, 18); font-size: 10pt; margin-top:
1.5em;">Bugs: </b> <a moz-do-not-send="true"
href="https://issues.asterisk.org/jira/browse/ASTERISK-17937">ASTERISK-17937</a>
</div>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt;
margin-top: 1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0pt;">
<li>/trunk/main/channel.c <span style="color: grey;">(331042)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="https://reviewboard.asterisk.org/r/1356/diff/"
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by <a class="moz-txt-link-freetext" href="http://www.api-digital.com">http://www.api-digital.com</a> --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
<a class="moz-txt-link-freetext" href="http://lists.digium.com/mailman/listinfo/asterisk-dev">http://lists.digium.com/mailman/listinfo/asterisk-dev</a></pre>
</blockquote>
</body>
</html>