<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1369/">https://reviewboard.asterisk.org/r/1369/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks like you got all the tests and I don&#39;t see any errors in the changeover.  Good to go!</pre>
 <br />







<p>- opticron</p>


<br />
<p>On August 16th, 2011, 2:34 p.m., Paul Belanger wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers and leifmadsen.</div>
<div>By Paul Belanger.</div>


<p style="color: grey;"><i>Updated Aug. 16, 2011, 2:34 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch defines our test modules as core.

https://wiki.asterisk.org/wiki/display/AST/Asterisk+Module+Support+States</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">testing is kinda a big deal!

Local development box.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/1.8/tests/test_acl.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_amihooks.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_aoc.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_app.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_ast_format_str_reduce.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_astobj2.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_db.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_devicestate.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_dlinklists.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_event.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_expr.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_func_file.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_gosub.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_heap.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_linkedlists.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_locale.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_logger.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_netsock2.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_pbx.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_poll.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_sched.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_security_events.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_skel.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_stringfields.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_strings.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_substitution.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_time.c <span style="color: grey">(332175)</span></li>

 <li>branches/1.8/tests/test_utils.c <span style="color: grey">(332175)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1369/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>