<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1364/">https://reviewboard.asterisk.org/r/1364/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 15th, 2011, 5:08 p.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I haven't tested this yet, however this look exciting! You've nailed one of the main issues with the testsuite; timing. So obvious questions come to mind about defining 'states' and documenting them properly, and then making sure the testsuite keeps in sync with them.
Also, we might not be able to merge this into 1.8, since this is a new feature, however we did backport some testing functionality into 1.4 previously.
I'll schedule some time this week to give this a run, and hopefully have more questions / comments then.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wasn't sure about it going into 1.8 either. This is a change that would definitely benefit the certified release of that version; but if we decide to put it into trunk, moving it over to that branch should be pretty easy.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 15th, 2011, 5:08 p.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1364/diff/1/?file=18401#file18401line6751" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/apps/app_voicemail.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int get_folder(struct ast_channel *chan, int start)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6751</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_test_suite_event_notify</span><span class="p">(</span><span class="s">"PLAYBACK"</span><span class="p">,</span> <span class="s">"Message: folder name %s"</span><span class="p">,</span> <span class="n">fn</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6751</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span> <span class="o">=</span> <span class="n">vm_play_folder_name</span><span class="p">(</span><span class="n">chan</span><span class="p">,</span> <span class="n">fn</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6752</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span> <span class="o">=</span> <span class="n">vm_play_folder_name</span><span class="p">(</span><span class="n">chan</span><span class="p">,</span> <span class="n">fn</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Assuming we decide to take this path, wouldn't it make sense just to wrap ast_test_suite_event_notify('PLAYBACK', ...) when ever Asterisk played back an audio file?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd think so. I updated ast_stream_and_wait and ast_play_and_wait to use the test event. That got rid of most of the instances in app_voicemail, save where it actually streams the file itself directly.</pre>
<br />
<p>- mjordan</p>
<br />
<p>On August 16th, 2011, 4:59 p.m., mjordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, David Vossel and Paul Belanger.</div>
<div>By mjordan.</div>
<p style="color: grey;"><i>Updated Aug. 16, 2011, 4:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review is part 1 of 2.
Previously, when attempting to write tests for complex applications, tests run into two problems:
1. The tests become inherently timing driven. For example, in an application that has a built in playback of a voice file, the test must use Wait(n) or some other sleep mechanism and attempt to wait until the voice prompt is finished before taking action. This can be even more difficult in those applications that have built in menus whose prompts can change based on the state of the application, such as app_voicemail's VoiceMailMain application.
2. Applications whose success is a hangup result can be difficult to verify. While UserEvent can be used in a dialplan to check certain return paths (thus determining whether an application definitely failed), it becomes difficult to say whether or not an application succeeds. For example, Dial has multiple success paths where the caller is hung up on; however, the hang up could also be an error in the dialplan. The only verification mechanism is by inspection.
The TestEvent manager event attempts to solve these two problems. It allows a developer to raise a manager event within an application that notifies the Asterisk Test Suite that something has happened in the application. Currently, this is one of two notifications:
1. A generic change in application state
2. A failure in an assert, indicating an off nominal condition
Both of these statements are macros that evaluate to nothing if the TEST_FRAMEWORK compilation flag is not defined, meaning they should have no impact on non-developer compiled code. While placing the manager events in the code perturbs the units under test, the methods are fairly small, and, in the context of sending audio over a channel for several seconds, are relatively small in terms of timing.
Part 2 of this review (1363) demonstrates a test in the Asterisk Test Suite using this new event. This diff also includes some initial hooks using the TestEvent in app_voicemail's VoiceMailMain application - I expect to add additional hooks as further tests are developed (the current ones check some of the nominal paths and operations)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/apps/app_voicemail.c <span style="color: grey">(331633)</span></li>
<li>/branches/1.8/configs/manager.conf.sample <span style="color: grey">(331633)</span></li>
<li>/branches/1.8/include/asterisk/manager.h <span style="color: grey">(331633)</span></li>
<li>/branches/1.8/include/asterisk/test.h <span style="color: grey">(331633)</span></li>
<li>/branches/1.8/main/app.c <span style="color: grey">(331633)</span></li>
<li>/branches/1.8/main/file.c <span style="color: grey">(331633)</span></li>
<li>/branches/1.8/main/manager.c <span style="color: grey">(331633)</span></li>
<li>/branches/1.8/main/test.c <span style="color: grey">(331633)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1364/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>